Skip to content

Implement hash for CompletableGithubObject #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

Implement hash for CompletableGithubObject #1922

merged 1 commit into from
Apr 26, 2021

Conversation

@s-t-e-v-e-n-k
Copy link
Collaborator

@s-t-e-v-e-n-k s-t-e-v-e-n-k commented Apr 18, 2021

Since CompletableGithubObject already uses its URL attribute to
implement equality, extend it to also use that attribute for hashing.

Fixes #1826
@s-t-e-v-e-n-k
Implement hash for CompletableGithubObject
4c0f051 
Since CompletableGithubObject already uses its URL attribute to implement equality, extend it to also use that attribute for hashing. Fixes PyGithub#1826
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@babcbcd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1922 +/- ## ========================================= Coverage ? 98.85% ========================================= Files ? 108 Lines ? 11062 Branches ? 0 ========================================= Hits ? 10935 Misses ? 127 Partials ? 0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update babcbcd...4c0f051. Read the comment docs.
@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit 4faff23 into PyGithub:master Apr 26, 2021
@s-t-e-v-e-n-k s-t-e-v-e-n-k deleted the hashable-classes branch October 21, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@s-t-e-v-e-n-k @codecov-commenter