Skip to main content
The Workplace

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

7
  • 12
    Yes, the first thing to do is to push for a proper code review process. That way everyone is invited to provide feedback and it doesn't feel so much like a personal thing. Once code reviews are in place, ensure the responses are not overly critical but instead are framed as possible enhancements (don't say "this is unreadable/hard to read" when you could instead say "this might be easier to read if you did XYZ"). Commented Apr 24, 2019 at 9:10
  • To avoid having to point out whitespace issues, make sure everyone has a linter plugin on their editor and if any issues get committed just add a comment saying there were lint errors added. Commented Apr 26, 2019 at 3:21
  • 2
    Agreed here... I would talk about best practices rather than focusing on comments on specific code that may come across as negative or personal attacks. Commented Apr 26, 2019 at 13:49
  • 1
    This is a much better answer than Snows, as this one actually suggests that seniors and "seniors" should find and follow good coding practices, rather than just write a bunch of junk and assume everyone else can understand it and that it's good simply because "it works for me". I've seen senior devs write code they couldn't understand a week later, as well as novices write very understandable code, even if it was a bit "simple". Commented Apr 26, 2019 at 17:28
  • For code, "a bit simple" is good :-) Commented Apr 19, 2021 at 23:01