Skip to content

Commit af72e6e

Browse files
authored
fix: An extra test that is still calling old JsonStreamWriter append (#760)
* fix:an extra test that is still calling old JsonStreamWriter append * .
1 parent 488f258 commit af72e6e

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/it/ITBigQueryWriteManualClientTest.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,7 @@ public void testJsonStreamWriterBatchWriteWithDefaultStream()
331331
row1.put("test_datetime", "2020-10-1 12:00:00");
332332
JSONArray jsonArr1 = new JSONArray(new JSONObject[] {row1});
333333

334-
ApiFuture<AppendRowsResponse> response1 =
335-
jsonStreamWriter.append(jsonArr1, -1, /* allowUnknownFields */ false);
334+
ApiFuture<AppendRowsResponse> response1 = jsonStreamWriter.append(jsonArr1, -1);
336335

337336
assertEquals(0, response1.get().getAppendResult().getOffset().getValue());
338337

@@ -350,11 +349,9 @@ public void testJsonStreamWriterBatchWriteWithDefaultStream()
350349
jsonArr3.put(row4);
351350

352351
LOG.info("Sending two more messages");
353-
ApiFuture<AppendRowsResponse> response2 =
354-
jsonStreamWriter.append(jsonArr2, -1, /* allowUnknownFields */ false);
352+
ApiFuture<AppendRowsResponse> response2 = jsonStreamWriter.append(jsonArr2, -1);
355353
LOG.info("Sending one more message");
356-
ApiFuture<AppendRowsResponse> response3 =
357-
jsonStreamWriter.append(jsonArr3, -1, /* allowUnknownFields */ false);
354+
ApiFuture<AppendRowsResponse> response3 = jsonStreamWriter.append(jsonArr3, -1);
358355
assertEquals(1, response2.get().getAppendResult().getOffset().getValue());
359356
assertEquals(3, response3.get().getAppendResult().getOffset().getValue());
360357

0 commit comments

Comments
 (0)