Skip to content

Commit b920cd5

Browse files
docs: Align session length with public documentation feat: Align ReadRows timeout with other versions of the API. (#1281)
- [ ] Regenerate this pull request now. Committer: @emkornfield PiperOrigin-RevId: 394308710 Source-Link: googleapis/googleapis@1549a69 Source-Link: https://github.com/googleapis/googleapis-gen/commit/40b5e7dd36d0b4a67f4cb41ad2e2f670700404ca
1 parent ed1ea00 commit b920cd5

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/BaseBigQueryReadClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ public BigQueryReadStub getStub() {
167167
* limits are enforced based on the number of pre-filtered rows, so some filters can lead to
168168
* lopsided assignments.
169169
*
170-
* <p>Read sessions automatically expire 24 hours after they are created and do not require manual
170+
* <p>Read sessions automatically expire 6 hours after they are created and do not require manual
171171
* clean-up by the caller.
172172
*
173173
* <p>Sample code:
@@ -220,7 +220,7 @@ public final ReadSession createReadSession(
220220
* limits are enforced based on the number of pre-filtered rows, so some filters can lead to
221221
* lopsided assignments.
222222
*
223-
* <p>Read sessions automatically expire 24 hours after they are created and do not require manual
223+
* <p>Read sessions automatically expire 6 hours after they are created and do not require manual
224224
* clean-up by the caller.
225225
*
226226
* <p>Sample code:
@@ -273,7 +273,7 @@ public final ReadSession createReadSession(
273273
* limits are enforced based on the number of pre-filtered rows, so some filters can lead to
274274
* lopsided assignments.
275275
*
276-
* <p>Read sessions automatically expire 24 hours after they are created and do not require manual
276+
* <p>Read sessions automatically expire 6 hours after they are created and do not require manual
277277
* clean-up by the caller.
278278
*
279279
* <p>Sample code:
@@ -313,7 +313,7 @@ public final ReadSession createReadSession(CreateReadSessionRequest request) {
313313
* limits are enforced based on the number of pre-filtered rows, so some filters can lead to
314314
* lopsided assignments.
315315
*
316-
* <p>Read sessions automatically expire 24 hours after they are created and do not require manual
316+
* <p>Read sessions automatically expire 6 hours after they are created and do not require manual
317317
* clean-up by the caller.
318318
*
319319
* <p>Sample code:

google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/stub/BigQueryWriteStubSettings.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -283,10 +283,10 @@ public static class Builder extends StubSettings.Builder<BigQueryWriteStubSettin
283283
.setInitialRetryDelay(Duration.ofMillis(100L))
284284
.setRetryDelayMultiplier(1.3)
285285
.setMaxRetryDelay(Duration.ofMillis(60000L))
286-
.setInitialRpcTimeout(Duration.ofMillis(5000L))
286+
.setInitialRpcTimeout(Duration.ofMillis(86400000L))
287287
.setRpcTimeoutMultiplier(1.0)
288-
.setMaxRpcTimeout(Duration.ofMillis(5000L))
289-
.setTotalTimeout(Duration.ofMillis(5000L))
288+
.setMaxRpcTimeout(Duration.ofMillis(86400000L))
289+
.setTotalTimeout(Duration.ofMillis(86400000L))
290290
.build();
291291
definitions.put("retry_policy_4_params", settings);
292292
settings =

grpc-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/v1beta2/BigQueryReadGrpc.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ public abstract static class BigQueryReadImplBase implements io.grpc.BindableSer
248248
* each stream will return the same number or rows. Additionally, the
249249
* limits are enforced based on the number of pre-filtered rows, so some
250250
* filters can lead to lopsided assignments.
251-
* Read sessions automatically expire 24 hours after they are created and do
251+
* Read sessions automatically expire 6 hours after they are created and do
252252
* not require manual clean-up by the caller.
253253
* </pre>
254254
*/
@@ -372,7 +372,7 @@ protected BigQueryReadStub build(io.grpc.Channel channel, io.grpc.CallOptions ca
372372
* each stream will return the same number or rows. Additionally, the
373373
* limits are enforced based on the number of pre-filtered rows, so some
374374
* filters can lead to lopsided assignments.
375-
* Read sessions automatically expire 24 hours after they are created and do
375+
* Read sessions automatically expire 6 hours after they are created and do
376376
* not require manual clean-up by the caller.
377377
* </pre>
378378
*/
@@ -475,7 +475,7 @@ protected BigQueryReadBlockingStub build(
475475
* each stream will return the same number or rows. Additionally, the
476476
* limits are enforced based on the number of pre-filtered rows, so some
477477
* filters can lead to lopsided assignments.
478-
* Read sessions automatically expire 24 hours after they are created and do
478+
* Read sessions automatically expire 6 hours after they are created and do
479479
* not require manual clean-up by the caller.
480480
* </pre>
481481
*/
@@ -567,7 +567,7 @@ protected BigQueryReadFutureStub build(
567567
* each stream will return the same number or rows. Additionally, the
568568
* limits are enforced based on the number of pre-filtered rows, so some
569569
* filters can lead to lopsided assignments.
570-
* Read sessions automatically expire 24 hours after they are created and do
570+
* Read sessions automatically expire 6 hours after they are created and do
571571
* not require manual clean-up by the caller.
572572
* </pre>
573573
*/

proto-google-cloud-bigquerystorage-v1beta2/src/main/proto/google/cloud/bigquery/storage/v1beta2/storage.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ service BigQueryRead {
6464
// limits are enforced based on the number of pre-filtered rows, so some
6565
// filters can lead to lopsided assignments.
6666
//
67-
// Read sessions automatically expire 24 hours after they are created and do
67+
// Read sessions automatically expire 6 hours after they are created and do
6868
// not require manual clean-up by the caller.
6969
rpc CreateReadSession(CreateReadSessionRequest) returns (ReadSession) {
7070
option (google.api.http) = {

0 commit comments

Comments
 (0)