Skip to content

Conversation

@kmjung
Copy link
Contributor

@kmjung kmjung commented Jul 15, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #418 ☕️

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #419 into master will increase coverage by 0.17%.
The diff coverage is 66.66%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #419 +/- ## ============================================ + Coverage 77.19% 77.36% +0.17%  - Complexity 565 574 +9  ============================================ Files 55 55 Lines 3367 3367 Branches 201 198 -3 ============================================ + Hits 2599 2605 +6  Misses 659 659 + Partials 109 103 -6 
Impacted Files Coverage Δ Complexity Δ
...rage/v1/stub/readrows/ApiResultRetryAlgorithm.java 86.95% <66.66%> (+8.69%) 12.00 <3.00> (+3.00)
...v1beta1/stub/readrows/ApiResultRetryAlgorithm.java 86.95% <66.66%> (+8.69%) 12.00 <3.00> (+3.00)
...v1beta2/stub/readrows/ApiResultRetryAlgorithm.java 86.95% <66.66%> (+8.69%) 12.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a27c5f...a3d6ae0. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 1584bdb into googleapis:master Jul 15, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.1.1...v1.2.0) (2020-07-16) ### Features * add 'Received Rst Stream' to automatic retry strings ([#419](https://www.github.com/googleapis/java-bigquerystorage/issues/419)) ([1584bdb](https://www.github.com/googleapis/java-bigquerystorage/commit/1584bdbf5820a378d844d333e8546b6a26b3c643)) ### Bug Fixes * BQTableSchemaToProtobufDescriptor will now only generate lower-cased fieldnames in the protobuf descriptor ([#415](https://www.github.com/googleapis/java-bigquerystorage/issues/415)) ([4672939](https://www.github.com/googleapis/java-bigquerystorage/commit/46729398eee0f728c3de731f803580342fbe787f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants