feat: add support for k8s_container resource type #207
Conversation
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #207 +/- ## ============================================ - Coverage 75.17% 74.98% -0.20% Complexity 593 593 ============================================ Files 42 42 Lines 3646 3662 +16 Branches 251 253 +2 ============================================ + Hits 2741 2746 +5 - Misses 757 768 +11 Partials 148 148
Continue to review full report at Codecov.
|
elharo left a comment
elharo left a comment There was a problem hiding this comment.
I think I'm going to start drawing a hard line on these reviews. You can cc me if it helps, but they must be sent to a Google SWE on the appropriate team, cloud logging in this case.
Who is your point of contact on the logging team? If there is no such person we need to find somebody.
There was a problem hiding this comment.
Looks like that's @simonz130 for this PR? That's fine then, but please wait for his approval.
| @simonz130 , @chingor13 PTAL |
elharo left a comment
elharo left a comment There was a problem hiding this comment.
LGTM but you should get an approval from @simonz130
product-auto-label bot added the api: logging 
| Hi there, any chance of having this merged anytime soon? Thanks |
| Any chance of merging this soon? Fluentd records these values by default in GKE, but the GCP Logback appender doesn't because of this lack of metadata. This PR will fix that problem and be very helpful to our ability to query this log data. |
| @simonz130 ,gentle ping |
simonz130 added priority: p2 5 participants
Fixes #206