fix: properly shutdown subscriber stub on permanent streaming pull failure #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.
lettering is not enabled
product-auto-label bot added the api: pubsub 
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #539 +/- ## ============================================ + Coverage 78.79% 78.81% +0.02% - Complexity 376 378 +2 ============================================ Files 27 27 Lines 3414 3418 +4 Branches 171 171 ============================================ + Hits 2690 2694 +4 Misses 651 651 Partials 73 73
Continue to review full report at Codecov.
|
kamalaboulhosn approved these changes Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When a subscriber fails permanently, we are not shutting down the stub, like we do during a normal shutdown. Making a change to shut down the subscriber stub on failure. Before shutting down the subscriber stub, we must first shut down the MessageDispatcher to verifying that all acks are processed first.
Fixes #315 ☕️