feat: expose default client configs #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.
lettering is not enabled
This reverts commit fef9956.
product-auto-label bot added the api: pubsub 
google-cla bot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #541 +/- ## ============================================ + Coverage 78.79% 78.86% +0.07% - Complexity 376 377 +1 ============================================ Files 27 27 Lines 3414 3416 +2 Branches 171 171 ============================================ + Hits 2690 2694 +4 + Misses 651 650 -1 + Partials 73 72 -1
Continue to review full report at Codecov.
|
anguillanneuf approved these changes Mar 2, 2021
hongalex approved these changes Mar 9, 2021
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #373 ☕️