Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Commit 03213c8

Browse files
feat: added field severity to findings (#216)
Clients will now see a new field, severity, on findings. They will also be able to filter and group by severity on ListFinding and GroupFinding API calls. PiperOrigin-RevId: 326514554 Source-Author: Google APIs <noreply@google.com> Source-Date: Thu Aug 13 13:43:22 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 5ad09e867a8f1faa19fbd674e51fa9c3f5fe2770 Source-Link: googleapis/googleapis@5ad09e8
1 parent 46fa555 commit 03213c8

31 files changed

+981
-693
lines changed

google-cloud-securitycenter/src/main/java/com/google/cloud/securitycenter/v1p1beta1/SecurityCenterClient.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,7 @@ public final UnaryCallable<CreateSourceRequest, Source> createSourceCallable() {
301301
*
302302
* @param parent Required. Resource name of the new finding's parent. Its format should be
303303
* "organizations/[organization_id]/sources/[source_id]".
304-
* @param findingId Required. Unique identifier provided by the client within the parent scope. It
305-
* must be alphanumeric and less than or equal to 32 characters and greater than 0 characters
306-
* in length.
304+
* @param findingId Required. Unique identifier provided by the client within the parent scope.
307305
* @param finding Required. The Finding being created. The name and security_marks will be ignored
308306
* as they are both output only fields on this resource.
309307
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
@@ -335,9 +333,7 @@ public final Finding createFinding(SourceName parent, String findingId, Finding
335333
*
336334
* @param parent Required. Resource name of the new finding's parent. Its format should be
337335
* "organizations/[organization_id]/sources/[source_id]".
338-
* @param findingId Required. Unique identifier provided by the client within the parent scope. It
339-
* must be alphanumeric and less than or equal to 32 characters and greater than 0 characters
340-
* in length.
336+
* @param findingId Required. Unique identifier provided by the client within the parent scope.
341337
* @param finding Required. The Finding being created. The name and security_marks will be ignored
342338
* as they are both output only fields on this resource.
343339
* @throws com.google.api.gax.rpc.ApiException if the remote call fails

proto-google-cloud-securitycenter-v1p1beta1/src/main/java/com/google/cloud/securitycenter/v1p1beta1/CreateFindingRequest.java

Lines changed: 24 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,6 @@ public com.google.protobuf.ByteString getParentBytes() {
198198
*
199199
* <pre>
200200
* Required. Unique identifier provided by the client within the parent scope.
201-
* It must be alphanumeric and less than or equal to 32 characters and
202-
* greater than 0 characters in length.
203201
* </pre>
204202
*
205203
* <code>string finding_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -223,8 +221,6 @@ public java.lang.String getFindingId() {
223221
*
224222
* <pre>
225223
* Required. Unique identifier provided by the client within the parent scope.
226-
* It must be alphanumeric and less than or equal to 32 characters and
227-
* greater than 0 characters in length.
228224
* </pre>
229225
*
230226
* <code>string finding_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -250,8 +246,8 @@ public com.google.protobuf.ByteString getFindingIdBytes() {
250246
*
251247
*
252248
* <pre>
253-
* Required. The Finding being created. The name and security_marks will be
254-
* ignored as they are both output only fields on this resource.
249+
* Required. The Finding being created. The name and security_marks will be ignored as
250+
* they are both output only fields on this resource.
255251
* </pre>
256252
*
257253
* <code>
@@ -268,8 +264,8 @@ public boolean hasFinding() {
268264
*
269265
*
270266
* <pre>
271-
* Required. The Finding being created. The name and security_marks will be
272-
* ignored as they are both output only fields on this resource.
267+
* Required. The Finding being created. The name and security_marks will be ignored as
268+
* they are both output only fields on this resource.
273269
* </pre>
274270
*
275271
* <code>
@@ -288,8 +284,8 @@ public com.google.cloud.securitycenter.v1p1beta1.Finding getFinding() {
288284
*
289285
*
290286
* <pre>
291-
* Required. The Finding being created. The name and security_marks will be
292-
* ignored as they are both output only fields on this resource.
287+
* Required. The Finding being created. The name and security_marks will be ignored as
288+
* they are both output only fields on this resource.
293289
* </pre>
294290
*
295291
* <code>
@@ -794,8 +790,6 @@ public Builder setParentBytes(com.google.protobuf.ByteString value) {
794790
*
795791
* <pre>
796792
* Required. Unique identifier provided by the client within the parent scope.
797-
* It must be alphanumeric and less than or equal to 32 characters and
798-
* greater than 0 characters in length.
799793
* </pre>
800794
*
801795
* <code>string finding_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -818,8 +812,6 @@ public java.lang.String getFindingId() {
818812
*
819813
* <pre>
820814
* Required. Unique identifier provided by the client within the parent scope.
821-
* It must be alphanumeric and less than or equal to 32 characters and
822-
* greater than 0 characters in length.
823815
* </pre>
824816
*
825817
* <code>string finding_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -842,8 +834,6 @@ public com.google.protobuf.ByteString getFindingIdBytes() {
842834
*
843835
* <pre>
844836
* Required. Unique identifier provided by the client within the parent scope.
845-
* It must be alphanumeric and less than or equal to 32 characters and
846-
* greater than 0 characters in length.
847837
* </pre>
848838
*
849839
* <code>string finding_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -865,8 +855,6 @@ public Builder setFindingId(java.lang.String value) {
865855
*
866856
* <pre>
867857
* Required. Unique identifier provided by the client within the parent scope.
868-
* It must be alphanumeric and less than or equal to 32 characters and
869-
* greater than 0 characters in length.
870858
* </pre>
871859
*
872860
* <code>string finding_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -884,8 +872,6 @@ public Builder clearFindingId() {
884872
*
885873
* <pre>
886874
* Required. Unique identifier provided by the client within the parent scope.
887-
* It must be alphanumeric and less than or equal to 32 characters and
888-
* greater than 0 characters in length.
889875
* </pre>
890876
*
891877
* <code>string finding_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -914,8 +900,8 @@ public Builder setFindingIdBytes(com.google.protobuf.ByteString value) {
914900
*
915901
*
916902
* <pre>
917-
* Required. The Finding being created. The name and security_marks will be
918-
* ignored as they are both output only fields on this resource.
903+
* Required. The Finding being created. The name and security_marks will be ignored as
904+
* they are both output only fields on this resource.
919905
* </pre>
920906
*
921907
* <code>
@@ -931,8 +917,8 @@ public boolean hasFinding() {
931917
*
932918
*
933919
* <pre>
934-
* Required. The Finding being created. The name and security_marks will be
935-
* ignored as they are both output only fields on this resource.
920+
* Required. The Finding being created. The name and security_marks will be ignored as
921+
* they are both output only fields on this resource.
936922
* </pre>
937923
*
938924
* <code>
@@ -954,8 +940,8 @@ public com.google.cloud.securitycenter.v1p1beta1.Finding getFinding() {
954940
*
955941
*
956942
* <pre>
957-
* Required. The Finding being created. The name and security_marks will be
958-
* ignored as they are both output only fields on this resource.
943+
* Required. The Finding being created. The name and security_marks will be ignored as
944+
* they are both output only fields on this resource.
959945
* </pre>
960946
*
961947
* <code>
@@ -979,8 +965,8 @@ public Builder setFinding(com.google.cloud.securitycenter.v1p1beta1.Finding valu
979965
*
980966
*
981967
* <pre>
982-
* Required. The Finding being created. The name and security_marks will be
983-
* ignored as they are both output only fields on this resource.
968+
* Required. The Finding being created. The name and security_marks will be ignored as
969+
* they are both output only fields on this resource.
984970
* </pre>
985971
*
986972
* <code>
@@ -1002,8 +988,8 @@ public Builder setFinding(
1002988
*
1003989
*
1004990
* <pre>
1005-
* Required. The Finding being created. The name and security_marks will be
1006-
* ignored as they are both output only fields on this resource.
991+
* Required. The Finding being created. The name and security_marks will be ignored as
992+
* they are both output only fields on this resource.
1007993
* </pre>
1008994
*
1009995
* <code>
@@ -1031,8 +1017,8 @@ public Builder mergeFinding(com.google.cloud.securitycenter.v1p1beta1.Finding va
10311017
*
10321018
*
10331019
* <pre>
1034-
* Required. The Finding being created. The name and security_marks will be
1035-
* ignored as they are both output only fields on this resource.
1020+
* Required. The Finding being created. The name and security_marks will be ignored as
1021+
* they are both output only fields on this resource.
10361022
* </pre>
10371023
*
10381024
* <code>
@@ -1054,8 +1040,8 @@ public Builder clearFinding() {
10541040
*
10551041
*
10561042
* <pre>
1057-
* Required. The Finding being created. The name and security_marks will be
1058-
* ignored as they are both output only fields on this resource.
1043+
* Required. The Finding being created. The name and security_marks will be ignored as
1044+
* they are both output only fields on this resource.
10591045
* </pre>
10601046
*
10611047
* <code>
@@ -1071,8 +1057,8 @@ public com.google.cloud.securitycenter.v1p1beta1.Finding.Builder getFindingBuild
10711057
*
10721058
*
10731059
* <pre>
1074-
* Required. The Finding being created. The name and security_marks will be
1075-
* ignored as they are both output only fields on this resource.
1060+
* Required. The Finding being created. The name and security_marks will be ignored as
1061+
* they are both output only fields on this resource.
10761062
* </pre>
10771063
*
10781064
* <code>
@@ -1092,8 +1078,8 @@ public com.google.cloud.securitycenter.v1p1beta1.FindingOrBuilder getFindingOrBu
10921078
*
10931079
*
10941080
* <pre>
1095-
* Required. The Finding being created. The name and security_marks will be
1096-
* ignored as they are both output only fields on this resource.
1081+
* Required. The Finding being created. The name and security_marks will be ignored as
1082+
* they are both output only fields on this resource.
10971083
* </pre>
10981084
*
10991085
* <code>

proto-google-cloud-securitycenter-v1p1beta1/src/main/java/com/google/cloud/securitycenter/v1p1beta1/CreateFindingRequestOrBuilder.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ public interface CreateFindingRequestOrBuilder
5959
*
6060
* <pre>
6161
* Required. Unique identifier provided by the client within the parent scope.
62-
* It must be alphanumeric and less than or equal to 32 characters and
63-
* greater than 0 characters in length.
6462
* </pre>
6563
*
6664
* <code>string finding_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -73,8 +71,6 @@ public interface CreateFindingRequestOrBuilder
7371
*
7472
* <pre>
7573
* Required. Unique identifier provided by the client within the parent scope.
76-
* It must be alphanumeric and less than or equal to 32 characters and
77-
* greater than 0 characters in length.
7874
* </pre>
7975
*
8076
* <code>string finding_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -87,8 +83,8 @@ public interface CreateFindingRequestOrBuilder
8783
*
8884
*
8985
* <pre>
90-
* Required. The Finding being created. The name and security_marks will be
91-
* ignored as they are both output only fields on this resource.
86+
* Required. The Finding being created. The name and security_marks will be ignored as
87+
* they are both output only fields on this resource.
9288
* </pre>
9389
*
9490
* <code>
@@ -102,8 +98,8 @@ public interface CreateFindingRequestOrBuilder
10298
*
10399
*
104100
* <pre>
105-
* Required. The Finding being created. The name and security_marks will be
106-
* ignored as they are both output only fields on this resource.
101+
* Required. The Finding being created. The name and security_marks will be ignored as
102+
* they are both output only fields on this resource.
107103
* </pre>
108104
*
109105
* <code>
@@ -117,8 +113,8 @@ public interface CreateFindingRequestOrBuilder
117113
*
118114
*
119115
* <pre>
120-
* Required. The Finding being created. The name and security_marks will be
121-
* ignored as they are both output only fields on this resource.
116+
* Required. The Finding being created. The name and security_marks will be ignored as
117+
* they are both output only fields on this resource.
122118
* </pre>
123119
*
124120
* <code>

0 commit comments

Comments
 (0)