Skip to content

Commit 3a3d465

Browse files
authored
fix: cleanup use of non-preferred terms (#411)
* replace poem with lorem ipsum in CloudStorageFileSystemProviderTest
1 parent 0d5ed3c commit 3a3d465

File tree

4 files changed

+30
-23
lines changed

4 files changed

+30
-23
lines changed

google-cloud-nio-retrofit/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ To run this example:
3737
[//]: # ({x-version-update-end})
3838
3939
The sample doesn't have anything about Google Cloud Storage in it. It gets that ability from the NIO
40-
jar that we're adding to the classpath. We use the NIO "fat shaded" jar for this purpose as it
40+
jar that we're adding to the classpath. We use the NIO "shaded" jar for this purpose as it
4141
also includes the dependencies for google-cloud-nio.
4242
The underlying mechanism is Java's standard
4343
[ServiceLoader](https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html)
@@ -47,7 +47,7 @@ to plug in NIO providers like this one.
4747
4848
If you have access to a project's source code you can also simply add google-cloud-nio as
4949
a dependency and let Maven pull in the required dependencies (this is what the NIO unit tests do).
50-
This approach is preferable as the fat jar approach may waste memory on multiple copies of
50+
This approach is preferable as the shaded jar approach may waste memory on multiple copies of
5151
dependencies.
5252
5353
[developers-console]:https://console.developers.google.com/

google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageOption.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.nio.file.CopyOption;
2020
import java.nio.file.OpenOption;
2121

22-
/** Master interface for file operation option classes related to Google Cloud Storage. */
22+
/** Main interface for file operation option classes related to Google Cloud Storage. */
2323
public interface CloudStorageOption {
2424

2525
/** Interface for Google Cloud Storage options that can be specified when opening files. */

google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/testing/LocalStorageHelper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ private LocalStorageHelper() {}
7070
public static StorageOptions getOptions() {
7171
instance.reset();
7272
return StorageOptions.newBuilder()
73-
.setProjectId("dummy-project-for-testing")
73+
.setProjectId("fake-project-for-testing")
7474
.setServiceRpcFactory(
7575
new ServiceRpcFactory<StorageOptions>() {
7676
@Override
@@ -87,7 +87,7 @@ public StorageRpc create(StorageOptions options) {
8787
*/
8888
public static StorageOptions customOptions(final boolean throwIfOptions) {
8989
return StorageOptions.newBuilder()
90-
.setProjectId("dummy-project-for-testing")
90+
.setProjectId("fake-project-for-testing")
9191
.setServiceRpcFactory(
9292
new ServiceRpcFactory<StorageOptions>() {
9393
@Override

google-cloud-nio/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java

Lines changed: 25 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -66,24 +66,31 @@ public class CloudStorageFileSystemProviderTest {
6666

6767
private static final List<String> FILE_CONTENTS =
6868
ImmutableList.of(
69-
"Fanatics have their dreams, wherewith they weave",
70-
"A paradise for a sect; the savage too",
71-
"From forth the loftiest fashion of his sleep",
72-
"Guesses at Heaven; pity these have not",
73-
"Trac'd upon vellum or wild Indian leaf",
74-
"The shadows of melodious utterance.",
75-
"But bare of laurel they live, dream, and die;",
76-
"For Poesy alone can tell her dreams,",
77-
"With the fine spell of words alone can save",
78-
"Imagination from the sable charm",
79-
"And dumb enchantment. Who alive can say,",
80-
"'Thou art no Poet may'st not tell thy dreams?'",
81-
"Since every man whose soul is not a clod",
82-
"Hath visions, and would speak, if he had loved",
83-
"And been well nurtured in his mother tongue.",
84-
"Whether the dream now purpos'd to rehearse",
85-
"Be poet's or fanatic's will be known",
86-
"When this warm scribe my hand is in the grave.");
69+
"Lorem ipsum dolor sit amet, consectetur ",
70+
"adipisicing elit. Ab, corporis deleniti ducimus ",
71+
"ea esse est fuga illum inventore itaque maiores ",
72+
"mollitia necessitatibus nesciunt nisi nobis non, ",
73+
"nulla officia omnis placeat quibusdam unde? Alias ",
74+
"delectus dignissimos, ducimus enim et expedita ",
75+
"iste molestiae mollitia porro sunt! Debitis ",
76+
"doloribus earum modi nam neque nulla optio ",
77+
"quisquam reprehenderit. Autem consequatur ",
78+
"delectus vitae. Aut consectetur cum eaque facere ",
79+
"illum in molestiae nam, nulla obcaecati officia ",
80+
"optio perspiciatis, quisquam reiciendis sequi ",
81+
"tempora, velit veritatis vitae? Alias ",
82+
"consequuntur dolor doloremque eius et fugiat ",
83+
"fugit harum illo incidunt ipsa maxime molestiae ",
84+
"nostrum officia pariatur, quam quidem similique ",
85+
"velit veniam voluptatem voluptatibus. Ab at ",
86+
"commodi ea expedita optio. Ab cumque eos et, ",
87+
"libero non quam quia recusandae tempora vitae! ",
88+
"Debitis libero quidem reprehenderit voluptas. ",
89+
"Architecto consectetur cum dignissimos, dolorem ",
90+
"eos, eum explicabo fugiat magnam maiores modi ",
91+
"numquam odio pariatur provident quae quasi quos ",
92+
"ratione recusandae repellendus similique ullam ",
93+
"velit!");
8794

8895
private static final String SINGULARITY = "A string";
8996

0 commit comments

Comments
 (0)