fix: npe in createFrom (#746)

* fix: npe in create-from * address NPE issue * revert test it * address unit tests

Author: frankyn

google-cloud-storage/src/main/java/com/google/cloud/storage/BlobWriteChannel.java

@@ -25,6 +25,7 @@
 import com.google.cloud.RetryHelper;
 import com.google.cloud.WriteChannel;
 import com.google.cloud.storage.spi.v1.StorageRpc;
+import com.google.common.collect.Maps;
 import java.net.URL;
 import java.util.Map;
 import java.util.concurrent.Callable;
@@ -77,7 +78,9 @@ private long getRemotePosition() {
  }
 
  private StorageObject getRemoteStorageObject() {
- return getOptions().getStorageRpcV1().get(getEntity().toPb(), null);
+ return getOptions()
+ .getStorageRpcV1()
+ .get(getEntity().toPb(), Maps.newEnumMap(StorageRpc.Option.class));
  }
 
  private StorageException unrecoverableState(

google-cloud-storage/src/test/java/com/google/cloud/storage/BlobWriteChannelTest.java

@@ -40,6 +40,7 @@
 import com.google.cloud.storage.spi.StorageRpcFactory;
 import com.google.cloud.storage.spi.v1.StorageRpc;
 import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.Maps;
 import java.io.IOException;
 import java.math.BigInteger;
 import java.net.MalformedURLException;
@@ -333,9 +334,10 @@ public void testWriteWithRetryAndObjectMetadata() throws IOException {
  .andThrow(socketClosedException);
  expect(storageRpcMock.getCurrentUploadOffset(eq(UPLOAD_ID))).andReturn(-1L);
  expect(storageRpcMock.getCurrentUploadOffset(eq(UPLOAD_ID))).andReturn(-1L);
- expect(storageRpcMock.get(BLOB_INFO.toPb(), null)).andThrow(socketClosedException);
+ expect(storageRpcMock.get(BLOB_INFO.toPb(), Maps.newEnumMap(StorageRpc.Option.class)))
+ .andThrow(socketClosedException);
  expect(storageRpcMock.getCurrentUploadOffset(eq(UPLOAD_ID))).andReturn(-1L);
- expect(storageRpcMock.get(BLOB_INFO.toPb(), null))
+ expect(storageRpcMock.get(BLOB_INFO.toPb(), Maps.newEnumMap(StorageRpc.Option.class)))
  .andReturn(BLOB_INFO.toPb().setSize(BigInteger.valueOf(MIN_CHUNK_SIZE)));
  replay(storageRpcMock);
  writer = new BlobWriteChannel(options, BLOB_INFO, EMPTY_RPC_OPTIONS);
@@ -485,7 +487,7 @@ public void testWriteWithLastFlushRetryChunkButCompleted() throws IOException {
  eq(true)))
  .andThrow(socketClosedException);
  expect(storageRpcMock.getCurrentUploadOffset(eq(UPLOAD_ID))).andReturn(-1L);
- expect(storageRpcMock.get(BLOB_INFO.toPb(), null))
+ expect(storageRpcMock.get(BLOB_INFO.toPb(), Maps.newEnumMap(StorageRpc.Option.class)))
  .andReturn(BLOB_INFO.toPb().setSize(BigInteger.valueOf(MIN_CHUNK_SIZE)));
  replay(storageRpcMock);
  writer = new BlobWriteChannel(options, BLOB_INFO, EMPTY_RPC_OPTIONS);