Skip to content

Excess comma in reserve_ids breaks the function #100

@Kazade

Description

@Kazade

See here: https://github.com/googleapis/python-datastore/blob/master/google/cloud/datastore/client.py#L888

This trailing comma makes message a tuple, and so the deprecation warning blows up with:

TypeError: expected string or bytes-like object 

Environment details

  • OS type and version: Fedora 32
  • Python version: python 3.8.5
  • pip version: 20.2.3
  • google-cloud-datastore version: 1.15.1

Steps to reproduce

  1. Use reserve_ids in Python code
  2. World ends.

Stack trace

 vi +891 .venv/lib/python3.8/site-packages/google/cloud/datastore/client.py # reserve_ids warnings.warn(message, DeprecationWarning) TypeError: expected string or bytes-like object 

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: datastoreIssues related to the googleapis/python-datastore API.triage meI really want to be triaged.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions