fix: smooth over system test bumps #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adds back some missing documentation to `CONTRIBUTING.rst` that covers creating indexes and populating test data for system tests. Also increases the number of `timestamp_key` entities created by `populate_datastore.py` to 10000, so that system tests can pass.
google-cla bot added the cla: yes Contributor Author
| If there's a more elegant way to do this, I'm open to suggestions. I didn't check in changes to |
tseaver approved these changes Aug 11, 2020
Contributor
| @chrisrossi If you don't check them in, then the bot will submit a PR tomorrow. No biggie. Usually, though, I check in |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds back some missing documentation to
CONTRIBUTING.rstthat coverscreating indexes and populating test data for system tests.
Also increases the number of
timestamp_keyentities created bypopulate_datastore.pyto 10000, so that system tests can pass.