feat(firestore): add client_options to base class (#148)

* feat(firestore): add client_options to base class * chore: bump g-c-c to 1.4.1 Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: Tres Seaver <tseaver@palladion.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>

Author: 3 people

google/cloud/firestore_v1/client.py

@@ -107,7 +107,10 @@ def __init__(
  # will have no impact since the _http() @property only lazily
  # creates a working HTTP object.
  super(Client, self).__init__(
- project=project, credentials=credentials, _http=None
+ project=project,
+ credentials=credentials,
+ client_options=client_options,
+ _http=None,
  )
  self._client_info = client_info
  if client_options:

setup.py

@@ -26,7 +26,7 @@
 release_status = "Development Status :: 5 - Production/Stable"
 dependencies = [
  "google-api-core[grpc] >= 1.14.0, < 2.0.0dev",
- "google-cloud-core >= 1.0.3, < 2.0dev",
+ "google-cloud-core >= 1.4.1, < 2.0dev",
  "pytz",
 ]
 extras = {}

tests/unit/v1/test_client.py

@@ -61,10 +61,12 @@ def test_constructor_with_emulator_host(self):
  getenv.assert_called_once_with(_FIRESTORE_EMULATOR_HOST)
 
  def test_constructor_explicit(self):
+ from google.api_core.client_options import ClientOptions
+
  credentials = _make_credentials()
  database = "now-db"
  client_info = mock.Mock()
- client_options = mock.Mock()
+ client_options = ClientOptions("endpoint")
  client = self._make_one(
  project=self.PROJECT,
  credentials=credentials,