feat: integrate limit to last #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
BenWhitehead reviewed Aug 6, 2020
Collaborator
BenWhitehead left a comment
BenWhitehead left a comment There was a problem hiding this comment.
Thanks for porting this over! Deferring to @crwilcox for final approval.
crwilcox reviewed Aug 7, 2020
| | ||
| async for _ in get_response: | ||
| pass | ||
| get_response = await collection.get() |
Contributor
There was a problem hiding this comment.
how does this map to the sync version?
Contributor Author
There was a problem hiding this comment.
Same functionality, now neither are Iterator/Generator/AsyncGenerators. Both aggregate results so they can be reversed and return a list, though the async function is a coroutine that has that functionality.
crwilcox approved these changes Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Integrate changes from #57 to the async client.