java can't compare strings

Question

i'm written a code that reads a line from the socket.
if the line is "bye" i want it to output "nice". from some reason it doesn't work, although i did try to output the input with no conditions and it did says "bye"

this is my code

 String input = null; if (socket.getInputStream().available() > 0) input = in.readLine(); if (input != null) { input = input.trim(); if (input == "bye") out.println("nice"); out.println(input); }

possible duplicate of Java String.equals versus ==

Matt Ball
– Matt Ball

2012-05-10 18:10:03 +00:00
Commented May 10, 2012 at 18:10 — Matt Ball
– Matt Ball, Commented May 10, 2012 at 18:10

Matt Ball · Accepted Answer · 2012-05-10 18:08:40Z

8

Use String#equals(), not ==, to compare strings.

answered May 10, 2012 at 18:08

Matt Ball

361k102 gold badges655 silver badges725 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ravi Jain · Accepted Answer · 2012-05-10 18:09:32Z

if (input != null) { input = input.trim(); if (input.equals("bye")) out.println("nice"); out.println(input); }

The equals() compares the content of string.

ametren · Accepted Answer · 2012-05-10 18:10:43Z

You want your inner if to say this:

if (input.equals("bye"))

instead of

if (input == "bye")

The == is actually comparing the reference object (sort of like a pointer) and may sometimes work when the string is interned, but that's another topic. Use .equals()!

Collectives™ on Stack Overflow

java can't compare strings

3 Answers 3

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Linked

Related