String comparison - Android [duplicate]

Question

I'm unable to compare two strings using the following code:

I have a string named "gender" which will have "Male" or "Female" as its value.

if(gender == "Male") salutation ="Mr."; if(gender == "Female") salutation ="Ms.";

This didn't work, so I tried the following:

String g1="Male"; String g2="Female"; if(gender.equals(g1)) salutation ="Mr."; if(gender.equals(g2)) salutation ="Ms.";

Again, it didn't work. Can someone please tell me how to compare string values using the if statement.

If that is not working, it is because gender is something else. Add this to figure it what is Log.d("GENDER", gender) — cutiko
– cutiko, Commented Mar 10, 2021 at 22:49

Linga · Accepted Answer · 2014-03-03 08:50:08Z

98

Try this

if(gender.equals("Male")) salutation ="Mr."; if(gender.equals("Female")) salutation ="Ms.";

Also remove ;(semi-colon ) in your if statement

if(gender.equals(g1));

In Java, one of the most common mistakes newcomers meet is using == to compare Strings. You have to remember, == compares the object references, not the content.

edited Mar 3, 2014 at 8:50

answered Apr 22, 2013 at 9:25

Linga

10.6k10 gold badges57 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Amokrane Chentir Over a year ago

If you explain why, I'll +1 this :)

Linga Over a year ago

Look at your code carefully and remove the ; at the end of both the if statements.

Raghav Kumar Over a year ago

Sorry, i wasn't using ; after the if stmt in my actual code, error while typing the question here!

Amokrane Chentir Over a year ago

@RaghavKumar What's the input?

1615903 Over a year ago

For null-safety, I always put the constant on the left side: if("Male".equals(gender))

|

Josh Crozier · Accepted Answer · 2015-12-11 01:31:46Z

String unlike int or other numeric variables are compared in Java differently than other languages.

To compare Strings in Java (android) it is used the method .compareTo();

so the code should be like this:

if(gender.compareTo("Male")==0){ salutation ="Mr."; } if(gender.compareTo("Female")==0){ salutation ="Ms."; }

SilentKiller · Accepted Answer · 2013-04-22 09:27:11Z

In Java we don't compare string as you are doing above... Here is String comparison...

 if (gender.equalsIgnoreCase("Male")) { salutation = "Mr."; } else if (gender.equalsIgnoreCase("Female")) { salutation = "Ms."; }

anjaly · Accepted Answer · 2013-04-22 09:32:36Z

8

I think the above mentioned answer is correct.Because == is for testing whether two strings are the same object,whereas .equals() tests whether two strings have the same value.

answered Apr 22, 2013 at 9:32

anjaly

5186 silver badges12 bronze badges

2 Comments

Dexter Over a year ago

This is a better explanation why not to use ==

tony gil Over a year ago

there is no "above" answer, for the order varies with number of votes. please edit and specify, if possible. tks

bema · Accepted Answer · 2013-04-22 09:28:51Z

The == operator checks to see if two objects are exactly the same object. Two strings may be different objects, but have the same value (have exactly the same characters in them). Use the .equals() method to compare strings for equality.

http://www.leepoint.net/notes-java/data/strings/12stringcomparison.html

midhunhk · Accepted Answer · 2013-04-22 09:30:12Z

Your gender == "Male" is actually comparing the object references for the object gender and a different object Male. What you have to use is the .equals() method to compare the value of the objects.

Shiv · Accepted Answer · 2013-04-22 09:26:18Z

try this

String g1="Male"; String g2="Female"; if(gender.equals(g1)) salutation ="Mr."; if(gender.equals(g2)) salutation ="Ms.";

you were ending your if statement if(gender.equals(g1)); <<--- here by adding ";"

Arun C · Accepted Answer · 2013-04-22 09:30:42Z

String g1="Male"; String g2="Female"; String salutation=""; String gender="Male"; if(gender.toLowerCase().trim().equals(g1.toLowerCase().trim())); salutation ="Mr."; if(gender.toLowerCase().trim().equals(g2.toLowerCase().trim())); salutation ="Ms.";

Imran Ali · Accepted Answer · 2013-04-22 09:31:31Z

try this.

 String g1 = "Male"; String g2 = "Female"; String gender = "Male"; String salutation = ""; if (gender.equalsIgnoreCase(g1)) salutation = "Mr."; else if (gender.equalsIgnoreCase(g2)) salutation = "Ms."; System.out.println("Welcome " + salutation);

Output:

Welcome Mr.

HMD · Accepted Answer · 2018-12-24 19:06:53Z

In addition if you want to compare if two strings are different, you can use :

String mystring = "something"; !mystring.equals("whatever")

It will return true!

Jainendra · Accepted Answer · 2013-04-22 09:28:14Z

This should work:

if(gender.equals("Male")){ salutation ="Mr."; } else if(gender.equals("Female")){ salutation ="Ms."; }

Remember, not to use ; after if statement.

Vipul · Accepted Answer · 2013-04-22 09:27:32Z

if(gender.equals(g1)); <--- if(gender == "Female"); <---

You have semicolon after if.REMOVE IT.

e1che · Accepted Answer · 2013-04-22 09:45:42Z

Actually every code runs well here, but your probleme probably come from your gender variable. Did you try to do a simple System.out.println(gender); before the comparaison ?

Ashwin Mothilal · Accepted Answer · 2016-04-06 18:49:55Z

0

You can use, contentEquals() function. It may help you..

answered Apr 6, 2016 at 18:49

Ashwin Mothilal

2,5321 gold badge20 silver badges24 bronze badges

Comments

Fahim Md. Riaz · Accepted Answer · 2018-05-11 20:42:12Z

This one work for me:

 if (email.equals("[email protected]") && pass.equals("123ss") ){ Toast.makeText(this,"Logged in",Toast.LENGTH_LONG).show(); } else{ Toast.makeText(this,"Logged out",Toast.LENGTH_LONG).show(); }

DiLDoST · Accepted Answer · 2021-03-10 22:39:43Z

Actually we could help better if we could see what is the input coming gender

However you can try following, maybe it's a case issue, like the incoming gender is male instead of Male

if(gender.equalsIgnoreCase("male"){ salutation = "Mr."; } else if(gender.equalsIgnoreCase("female"){ salutation = "Ms."; }

Or if this didn't worked, try getting the gender and let us know what it is, so we can help better. You can print gender like this

System.out.println(gender);

You may see the output on the Console on your IDE

bummi · Accepted Answer · 2016-03-22 05:21:05Z

-1

Try it:

if (Objects.equals(gender, "Male")) { salutation ="Mr."; } else if (Objects.equals(gender, "Female")) { salutation ="Ms."; }

edited Mar 22, 2016 at 5:21

bummi

27.4k14 gold badges67 silver badges105 bronze badges

answered Mar 22, 2016 at 4:37

Quang Dai Ngo

411 silver badge5 bronze badges

Collectives™ on Stack Overflow

String comparison - Android [duplicate]

17 Answers 17

7 Comments

Comments

Comments

2 Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

17 Answers 17

7 Comments

Comments

Comments

2 Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Linked

Related