Do I need to wait for asynchronous method to complete before disposing HttpClient?

Question

I wonder if this code works as expected (send a string to a web application):

using (HttpClient httpClient = Util.CreateHttpClient()) { httpClient.PostAsJsonAsync("theurl", somestr); }

Since PostAsJsonAsync doesn't complete execution immediately, and httpClient is disposed when exiting the block, is the request always sent properly?

Or do I have to wait for the task like this:

using (HttpClient httpClient = Util.CreateHttpClient()) { httpClient.PostAsJsonAsync("theurl", somestr).Wait(); }

Yuval Itzchakov · Accepted Answer · 2014-10-22 04:36:45Z

When using the asynchronous API of HttpClient, its recommended you await these methods:

using (HttpClient httpClient = Util.CreateHttpClient()) { await httpClient.PostAsJsonAsync("theurl", somestr); }

That way, you ensure completion of the asynchronous method and you make sure HttpClient isn't disposed until the request is sent.

If you need a synchronous API, consider looking at WebClient.

matt-dot-net · Accepted Answer · 2014-10-22 04:29:27Z

0

You have to wait or keep the client in scope.

answered Oct 22, 2014 at 4:29

matt-dot-net

4,24423 silver badges24 bronze badges

1 Comment

Maria Ines Parnisari Over a year ago

Do you have a source for this?

Collectives™ on Stack Overflow

Do I need to wait for asynchronous method to complete before disposing HttpClient?

2 Answers 2

Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Related