Mysqli update query doesn't work

Question

So I'm trying to build a kind of update email function, and the part that should put it into the db looks like this

<?php $emailfrom = $_POST['emailfrom']; $emailto = $_POST['emailto']; $query = sprintf('UPDATE `users` SET `email`="%s" WHERE `email`="%s"`', mysqli_real_escape_string($db, $emailfrom), mysqli_real_escape_string($db, $emailto)); mysqli_query($db, $query);

The problem is that the row don't update... And I need help in knowing why, as I'm not so well experienced with mysql, used other dbs mainly earlier

sunshinejr · Accepted Answer · 2015-06-06 17:27:57Z

1

You've got syntax error in your query.

 \/ $query = sprintf('UPDATE `users` SET `email`= "%s" WHERE `email`= "%s"`', mysqli_real_escape_string($db, $emailfrom), mysqli_real_escape_string($db, $emailto)); mysqli_query($db, $query);

Also, you probably want to change emails from emailFrom to emailTo, now you are doing it the other way around. After edit:

$query = sprintf('UPDATE `users` SET `email`= "%s" WHERE `email`= "%s"`', mysqli_real_escape_string($db, $emailto), mysqli_real_escape_string($db, $emailfrom)); mysqli_query($db, $query);

edited Jun 6, 2015 at 17:27

answered Jun 6, 2015 at 12:09

sunshinejr

4,8442 gold badges24 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Svante Over a year ago

Nope, still doesn't work, and what exactly is the error with email

sunshinejr Over a year ago

You have additional ` in the end of the string. Change email= "%s"` to email= "%s"

sunshinejr Over a year ago

Now you got the syntax right. I edited my answer, if I'm correct you are updating your row the other way around. Otherwise I don't have any idea left why your query isn't working, since syntax is okay, the code you posted also. Try debugging with error_reporting.

Svante Over a year ago

That made it! Thousands of thanks, I'm feeling pretty stupid now, it was so obvious when you said It...

sunshinejr Over a year ago

Haha, don't worry, common mistake made by tired people :) Glad you got it.

Thomas Williams · Accepted Answer · 2017-05-28 09:50:45Z

The accepted answer will work, but a prepared statement would be much safer

$query="UPDATE `users` SET `email`= ? WHERE `email`= ?"; $stmt = $db->prepare($query); $stmt->bind_param('ss',$_POST['emailfrom'],$_POST['emailto']); $stmt->execute(); $stmt->close();

With a prepared statement you don't have to worry about escaping your variables to prevent SQL injection.

Collectives™ on Stack Overflow

Mysqli update query doesn't work

2 Answers 2

5 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Related