Indexof() returning -1

Question

Been making a simple form + data validation thing, I'm using indexof to make sure there is a "@" and "." in the email address, but it is always returning -1.

var custEmail = document.getElementById("custEmail"); if (custEmail.value == "" || custEmail.value.indexOf("@" == -1) || custEmail.value.indexOf("." == -1)) { alert("You must enter a valid Email address!\n" }

I've tried changing the indexof check to different letters instead of the symbols, but it still returns -1, which makes me think I'm trying to get the data incorrectly.

it's custEmail.value.indexOf("@") == -1, not indexOf("@" == -1) — Roco CTZ
– Roco CTZ, Commented May 29, 2016 at 4:18
Oh my god I'm an idiot. I blame lack of sleep. This was it. Thanks. — Luke Victory
– Luke Victory, Commented May 29, 2016 at 4:20

jdigital · Accepted Answer · 2016-05-29 04:19:16Z

3

your parens are in the wrong place

custEmail.value.indexOf("@") == -1 || custEmail.value.indexOf(".") == -1

answered May 29, 2016 at 4:19

jdigital

12.4k4 gold badges38 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rahul Arora · Accepted Answer · 2016-05-29 04:23:26Z

0

You can use HTML5 input type email rather than writing validations yourself

<input type="email"/>

answered May 29, 2016 at 4:23

Rahul Arora

4,5431 gold badge19 silver badges25 bronze badges

2 Comments

Luke Victory Over a year ago

This is more of a skills exercise than something that is supposed to be completely functional, which is why I wanted to do it manually.

Rahul Arora Over a year ago

Okay great, you also use regex to do validations like these as a part of skill development

Collectives™ on Stack Overflow

Indexof() returning -1

2 Answers 2

Comments

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Related