const QPointF points[] = { QPointF(r.left() - i, r.top() - i), QPointF(r.right() + i, r.top() - i), QPointF(r.right() + i, r.bottom() + i), QPointF(r.left() - i, r.bottom() + i), points[0] // is this line valid (according to the C++ standard)? }; While this compiles with the MS Visual Studio Compiler, i am not sure if this is valid code according to the C++ Standard.
Quotes from the Standard would be highly appreciated.
C++03/C++11 answer
No, it's not.
On the right-hand side of the =, points does exist1 but the initialiser is only applied after all its operands have been evaluated.
If points is at namespace scope (and thus has static storage duration and has been zero-initialized2), then this is "safe" but your use of points[0] there is going to give you 0, rather than QPointF(r.left() - i, r.top() - i) again.
If points has automatic storage duration — it has not yet been initialised so your use of points[0] is attempting to use an uninitialised variable, where points[0] has an indeterminate value... which is bad3.
It's difficult to provide standard references for this, other than to say that there is nothing in 8.5 "Initializers" that explicitly makes this possible, and rules elsewhere fill in the rest.
1
[n3290: 3.3.2/1]:The point of declaration for a name is immediately after its complete declarator (Clause 8) and before its initializer (if any), except as noted below. [ Example:int x = 12; { int x = x; }Here the second
xis initialized with its own (indeterminate) value. —end example ]2
[n3290: 3.6.2/2]:Variables with static storage duration (3.7.1) or thread storage duration (3.7.2) shall be zero-initialized (8.5) before any other initialization takes place. [..]3
[n3290: 17.6.3.3/2]:[..] [ Note: Operations involving indeterminate values may cause undefined behavior. —end note ]
from http://www.comeaucomputing.com/pcgi-bin/compiler.cgi:
Copyright 1988-2008 Comeau Computing. All rights reserved. MODE:strict errors C++ C++0x_extensions "ComeauTest.c", line 8: warning: variable "points" is used before its value is set points[0] // is this line valid (according to the C++ standard)? Since there is no sequence point in the statement, the result is undefined, much like for the i=i++ example quoted at that wikipedia page.
Otherwise said, nothing specifies, whether the compiler should first evaluate everything, then assign, or do evaluate-assign for each element separately and in which order.
{.., ..} is not the "comma operator" in this context. (Similar to the wikipedia article referenced, sub pt. 4: "Note that a function call f(a,b,c) is not a use of the comma operator and the order of evaluation for a, b, and c is unspecified.")Old Answer (misses the point):
I checked the current C++0x draft, and there i found the sentence 8.5.1.17 which says:
17 The full-expressions in an initializer-clause are evaluated in the order in which they appear.
So while this sentence is not part of the C++ Standard from 2003, im quite sure that this should be working in any up to date compiler, if this is part of C++0x.
Edit:
The comments made me rethink this matter. This line only ensures that the QPointF objects are created in the order in which they occur in the array initialization (relevant if the element constructors have observable side-effects). The problem is, the value of points is indeterminate during its array initialization. So there cant be a guarantee for a valid value of points[0] either, at least not if you rely on the standard.
g++ -pedanticdoesn't complain.const int x = x;either.points[0]does not refer to a valid object "by that time".points[0]has an indeterminate value.