Use input variable in assert or specify the data to assert

Question

I have a unit test for a function that adds data (untransformed) to the database. The data to insert is given to the create function. Do I use the input data in my asserts or is it better to specify the data that I’m asserting?

For eample:

$personRequest = [ 'name'=>'John', 'age'=>21, ]; $id = savePerson($personRequest); $personFromDb = getPersonById($id); $this->assertEquals($personRequest['name'], $personFromDb['name']); $this->assertEquals($personRequest['age'], $personFromDb['age']);

Or

$id = savePerson([ 'name'=>'John', 'age'=>21, ]); $personFromDb = getPersonById($id); $this->assertEquals('John', $personFromDb['name']); $this->assertEquals(21, $personFromDb['age']);

I Am · Accepted Answer · 2017-03-13 11:11:04Z

I think 1st option is better. Your input data may change in future and if you go by 2nd option, you will have to change assertion data everytime.

2nd option is useful, when your output is going to be same irrespective of your input data.

Rickyrick · Accepted Answer · 2017-03-16 07:02:24Z

I got an answer from Adam Wathan by e-mail. (i took his test driven laravel course and noticed he uses the 'specify' option)

I think it's just personal preference, I like to be able to visually skim and see "ok this specific string appears here in the output and here in the input", vs. trying to avoid duplication by storing things in variables." Nothing wrong with either approach in my opinion!

So i can't choose a correct answer.

Collectives™ on Stack Overflow

Use input variable in assert or specify the data to assert

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related