Angular Uncaught Error: Can't resolve all parameters for service

Question

I don't understand why this service doesn't work? Is it some problem with dependencies?

service:

import { Http } from '@angular/http'; export class GetWeatherService { constructor(private http: Http) {} getWeather() { return this.http.get(link); } }

and component:

import { Component, OnInit } from '@angular/core'; import { GetWeatherService } from './get-weather.service'; @Component({ selector: 'app-form', templateUrl: './form.component.html', styleUrls: ['./form.component.css'], providers: [GetWeatherService] }) export class FormComponent implements OnInit { constructor(public getWeather: GetWeatherService) {} ngOnInit() { this.getWeather.getWeather(); } }

hagner's answer is what you need, but may I also suggest using the new HttpClient instead of 'Http'. It has a number of improvements :-) — diopside
– diopside, Commented Aug 26, 2017 at 14:58

hagner · Accepted Answer · 2017-08-26 14:57:21Z

4

You need to make your service injectable:

@Injectable() export class GetWeatherService { //CODE }

answered Aug 26, 2017 at 14:57

hagner

1,0499 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Hubert Over a year ago

I thought I was adding Injectable decorator when I want inject dependency to this service from another service. Thank's a lot. It works. Greetings

Suren Srapyan · Accepted Answer · 2017-08-26 14:58:17Z

Add @Injectable() over your service to let it be injected into constructors.

import { Http } from '@angular/http'; import { Injectable } from '@angular/core'; @Injectable() export class GetWeatherService { constructor(private http: Http) {} getWeather() { return this.http.get(link); } }

Collectives™ on Stack Overflow

Angular Uncaught Error: Can't resolve all parameters for service

2 Answers 2

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Related