playing with java Operators (XOR and AND/OR)

Question

In a program I am trying to check two boolean values (returned from a function); the condition that needs to be checked is:
- only if any one of the returned value is true and the other is false then I have a problem;
- else if both are true or false I am good to go to next step.

Which of the following two examples would be the efficient way to check the condition, or is there a better solution?
a and b are integer values on which I am checking a condition for correctness in isCorrect function and it return true or false.

1.

 // checking for the correctness of both a and b if ((isCorrect(a) && !isCorrect(b)) || (!isCorrect(a) && isCorrect(b))) { // a OR b is incorrect } else { // a AND b are both correct or incorrect }

2.

 // checking for the correctness of both a and b if (! (isCorrect(a) ^ isCorrect(b))) { // a OR b is incorrect } else { // a AND b are correct or incorrect }

Thanks,
Ivar

P.S: code readability is not an issue. EDIT: I meant to have an XOR in the second option. Also, I agree with the == and != options, but what if I had to use boolean operators?

Your second example seems to have a mistake.

Nikita Rybak
– Nikita Rybak

2011-01-18 19:35:26 +00:00
Commented Jan 18, 2011 at 19:35 — Nikita Rybak
– Nikita Rybak, Commented Jan 18, 2011 at 19:35
@Nikita: Indeed, closing bracket.

Martijn Courteaux
– Martijn Courteaux

2011-01-19 19:11:47 +00:00
Commented Jan 19, 2011 at 19:11 — Martijn Courteaux
– Martijn Courteaux, Commented Jan 19, 2011 at 19:11

pingw33n · Accepted Answer · 2011-01-18 19:31:22Z

6

if (isCorrect(a) != isCorrect(b)) { // a OR b is incorrect } else { // a AND b are correct or incorrect }

answered Jan 18, 2011 at 19:31

pingw33n

12.6k2 gold badges39 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Erick Robertson Over a year ago

+1 simple, to the point, and in the same order as the question with the same comments

Alnitak Over a year ago

that doesn't mean that the comments were actually meaningful though ;-)

Erick Robertson Over a year ago

Agreed, but the OP will have an easier time following.

Alnitak · Accepted Answer · 2011-01-18 19:52:08Z

Your test doesn't need boolean operators, just this:

if (isCorrect(a) == isCorrect(b)) { // they both have the same value } else { // they don't ... }

EDIT - I deliberately didn't use the same comments to reflect that the primary purpose of the comment should be to describe the intent, and not the specific implementation. In this case the simplest statement of intent is that both a and b obtained the same result.

Garis M Suero · Accepted Answer · 2011-01-18 19:32:35Z

simply:

 if (isCorrect(a) == isCorrect(b)) { // a AND b are both correct or incorrect } else { // a OR b is incorrect }

Brian Ball · Accepted Answer · 2011-01-18 19:33:15Z

How about this?

if(isCorrect(a) != isCorrect(b)) { //problem } else { //not a problem }

You can use XOR also, but != works fine and is more readable if you are dealing with boolean values, IMO.

Collectives™ on Stack Overflow

playing with java Operators (XOR and AND/OR)

4 Answers 4

3 Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Related