How to encode an url

Question

NSString* urlEncode(NSString * url) { string inStr = StringFromNSString(url); CFStringRef inStringRef = CFStringCreateWithCString( kCFAllocatorDefault, inStr.c_str(), kCFStringEncodingUTF8 ); NSString * encodedString = (NSString *)CFURLCreateStringByAddingPercentEscapes(NULL,(CFStringRef)inStringRef,NULL,(CFStringRef)@"!*’();:@&=+$,/?%#[]",kCFStringEncodingUTF8 ); return encodedString; }

I am using above method to encode url... even though my app is crashing saying

<body> <div id="content"> <h1>An Error Was Encountered</h1> <p>The URI you submitted has disallowed characters.</p> </div> </body> </html> terminate called after throwing an instance of 'std::invalid_argument' what():

Any idea.. What is wrong with my code?

FYI: It is crashing in this method JSONNode jsonObject0 = libJSON::parse( inResponseData );

UPDATED: The server which i am sending message is UNIX server is it causing problem?

providing the actual URL you are sending would be helpful..

reflog
– reflog

2011-01-27 10:17:15 +00:00
Commented Jan 27, 2011 at 10:17 — reflog
– reflog, Commented Jan 27, 2011 at 10:17

darronschall · Accepted Answer · 2011-01-27 15:40:13Z

You don't need to create the inStr or inStringRef temporary variables. The types NSString* and CFStringRef are "toll free bridge" types. These types are interchangable with just a simple cast.

You can find more information about toll free bridging here: http://www.mikeash.com/pyblog/friday-qa-2010-01-22-toll-free-bridging-internals.html

That said, you can simplify your method to just the following:

-(NSString*) urlEncode { NSString *encodedString = (NSString *)CFURLCreateStringByAddingPercentEscapes( NULL, (CFStringRef)self, NULL, (CFStringRef)@"!*'();:@&=+$,/?%#[]", kCFStringEncodingUTF8 ); return [encodedString autorelease]; }

The above is best implemented as an NSString category (note the use of self as the value to encode).

richard · Accepted Answer · 2011-01-27 10:17:49Z

This works fine for me. I use CFSTR instead of (CFStringRef)@"!*’();:@&=+$,/?%#[]"

- (NSString *)encodedURLParameterString { NSString *result = (NSString *)CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, (CFStringRef)self, NULL, CFSTR(":/=,!$& '()*+;[]@#?"), kCFStringEncodingUTF8); return [result autorelease]; }

Nishant · Accepted Answer · 2013-05-28 19:23:22Z

You can try this

NSString *sampleUrl = @"http://www.google.com/search.jsp?params=Java Developer"; NSString* encodedUrl = [sampleUrl stringByAddingPercentEscapesUsingEncoding: NSASCIIStringEncoding];

Dave DeLong · Accepted Answer · 2011-01-27 17:57:21Z

You need to make sure that you're not URL encoding more than you need. If you're going to be using this encoding string as part of an actual URL, then you should know that there are only portions of the URL that are supposed to be encoded, namely the query string (there are other bits as well, but 95% of the time, this has to do with the query).

In other words, your URL should be:

scheme://host/path?<key>=<value>&<key>=<value>

In this, ONLY the stuff inside the angle brackets (<key> and <value>) should be URL encoded.

Chandan Shetty SP · Accepted Answer · 2011-02-07 08:34:58Z

1

It was the problem in UNIX server... It was giving wrong data.

answered Feb 7, 2011 at 8:34

Chandan Shetty SP

5,1176 gold badges45 silver badges63 bronze badges

Comments

Toon Krijthe · Accepted Answer · 2012-11-28 06:37:51Z

NSString *encodedstring = (__bridge NSString *)CFURLCreateStringByAddingPercentEscapes(NULL, (__bridge CFStringRef)yoururlstring, NULL, (CFStringRef)@"!*'();:@&=+$,/?%#[]", kCFStringEncodingUTF8);

this code works perfect

Narendra G · Accepted Answer · 2017-08-22 10:38:20Z

Here is the best way to encode the formatted URLString:

urlString = [urlString stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLQueryAllowedCharacterSet]];

Instead of using below as it has some memory management issues.

NSString *encodedstring = (__bridge NSString *)CFURLCreateStringByAddingPercentEscapes(NULL, (__bridge CFStringRef)yoururlstring, NULL, (CFStringRef)@"!*'();:@&=+$,/?%#[]", kCFStringEncodingUTF8);

Collectives™ on Stack Overflow

How to encode an url

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Related