Spring problems injecting Clock as a constructor argument

Question

I have a class that takes a java.time.Clock object as a constructor argument. I am having problems defining this as a bean in the applicationContext.xml file:

TimeTracker.java

public class TimeTracker{ public final Clock clock; public TimeTracker(Clock clock){ this.clock = clock; }

applicationContext.xml

<bean id="timeTracker" class="com.tracker.TimeTracker"> <constructor-arg type="java.time.Clock" value=""/> </bean>

The error I am having is: Ambiguous constructor argument types - did you specify the correct bean references as constructor arguments?

do you have other constructors in the class time tracker?

Veselin Davidov
– Veselin Davidov

2018-06-13 09:51:59 +00:00
Commented Jun 13, 2018 at 9:51 — Veselin Davidov
– Veselin Davidov, Commented Jun 13, 2018 at 9:51
no, I have no other constructor for the class

OneXer
– OneXer

2018-06-13 09:53:11 +00:00
Commented Jun 13, 2018 at 9:53 — OneXer
– OneXer, Commented Jun 13, 2018 at 9:53

Strelok · Accepted Answer · 2018-06-13 10:18:19Z

3

Try it like this:

<bean class=“java.time.Clock” factory-method=“java.time.Clock.systemDefaultZone” name=“clock”/> <bean id="timeTracker" class="com.tracker.TimeTracker"> <constructor-arg ref=“clock”/> </bean>

The value attribute is for primitive types only.

edited Jun 13, 2018 at 10:18

answered Jun 13, 2018 at 9:51

Strelok

51.7k9 gold badges106 silver badges118 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

OneXer Over a year ago

thanks for the explanation Strelok. I tried your answer , but I get the following: Could not instantiate bean class java.time.Clock: Is it an abstract class? This is true as Clock is an abstract class

Strelok Over a year ago

Sorry I missed the fact that the Clock constructor is protected and you have to get an instance via a factory method. I updated the answer.

Ayub Malik · Accepted Answer · 2018-06-13 09:51:52Z

You need to instantiate a clock and use it as a reference. Something similar to:

<bean id="clock" class="java.time.clock"/> <bean id="timeTracker" class="com.tracker.TimeTracker"> <constructor-arg type="java.time.Clock" ref="clock"/> </bean>

Antho Christen · Accepted Answer · 2018-06-13 09:52:45Z

Try,

<bean id="timeTracker" class="com.tracker.TimeTracker"> <constructor-arg> <bean class="java.time.Clock" factory-method="java.time.Clock.systemUTC" /> </constructor-arg> </bean>

borjab · Accepted Answer · 2018-07-24 14:03:32Z

The solution from Strelok nearly works but it failed for me as you do not need to define the full path of the factory method. It is relative to the factory Class so if you type factory-method=“java.time.Clock.systemDefaultZone” it will look for a method in java.time.Clock.java.time.Clock.systemDefaultZone().

<bean id="systemClock" class="java.time.Clock" factory-method="systemUTC" /> <bean id="timeTracker" class="com.tracker.TimeTracker"> <constructor-arg type="java.time.Clock" ref="systemClock"/> </bean>

To makes things worse the Spring exception is not especially helpful.

Tomek Samcik · Accepted Answer · 2018-10-26 06:22:53Z

Strelok's answer almost works, it should be -

<bean name=“clock” class=“java.time.Clock” factory-method=“systemDefaultZone” />

Collectives™ on Stack Overflow

Spring problems injecting Clock as a constructor argument

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

Comments

Comments

Related