99

I wrote this code to disable submit buttons on my website after the click:

$('input[type=submit]').click(function(){ $(this).attr('disabled', 'disabled'); }); 

Unfortunately, it doesn't send the form. How can I fix this?

EDIT I'd like to bind the submit, not the form :)

1

16 Answers 16

178

Do it onSubmit():

$('form#id').submit(function(){ $(this).find(':input[type=submit]').prop('disabled', true); }); 

What is happening is you're disabling the button altogether before it actually triggers the submit event.

You should probably also think about naming your elements with IDs or CLASSes, so you don't select all inputs of submit type on the page.

Demonstration: http://jsfiddle.net/userdude/2hgnZ/

(Note, I use preventDefault() and return false so the form doesn't actual submit in the example; leave this off in your use.)

Sign up to request clarification or add additional context in comments.

16 Comments

Yeah, in fact I really want to bind ALL submit in the page. So I don't mind about ID or CLASS in this way :) Tryed with $('input[type=submit]').submit(function() : the form is sent, but the button wont disable anymore...
You need to put the submit() on the form, not the input. See the demo.
Yeah it works! The only problem is that I have a onSubmit function on form, so that's bind by jquery shadow it! I need to implement this on my original function, or change the whole call! Thanks
In my case I needed to wrap this in $(document).ready to get it to work. Probably obvious. What wasn't obvious and took a bit of work to figure out is that if the program that is receiving the POST (or GET) is looking for the value of the submit button, if it's disabled then it won't be included in the POST values. At least that's what my testing showed.
If you want to pass the value of the input button to the $_POST it won't work if the button is disabled
|
43

Specifically if someone is facing problem in Chrome:

What you need to do to fix this is to use the onSubmit tag in the <form> element to set the submit button disabled. This will allow Chrome to disable the button immediately after it is pressed and the form submission will still go ahead...

<form name ="myform" method="POST" action="dosomething.php" onSubmit="document.getElementById('submit').disabled=true;"> <input type="submit" name="submit" value="Submit" id="submit"> </form> 

3 Comments

This is not what the major part of developers want. Javascript stuff should not be inline in the HTML code. Probably using .on('submit', function() {..}) (or .submit(function() {..})) would be better. Even if in this case you could have problems retriggering .submit() on the form from inside the callback, falling in an endless loop (at least on a recent version of Opera I'm using, that should use the same engine as Chrome).
This was exactly what I was looking for. A simple inline that doesn't require external libs and doesn't get into way even if JavaScript is disabled.
Tested this on a form with JQuery validation that prevents the submit if validation fails, and ended up with the submit button still being disabled by this answer.
16

Disabled controls do not submit their values which does not help in knowing if the user clicked save or delete.

So I store the button value in a hidden which does get submitted. The name of the hidden is the same as the button name. I call all my buttons by the name of button.

E.g. <button type="submit" name="button" value="save">Save</button>

Based on this I found here. Just store the clicked button in a variable.

$(document).ready(function(){ var submitButton$; $(document).on('click', ":submit", function (e) { // you may choose to remove disabled from all buttons first here. submitButton$ = $(this); }); $(document).on('submit', "form", function(e) { var form$ = $(this); var hiddenButton$ = $('#button', form$); if (IsNull(hiddenButton$)) { // add the hidden to the form as needed hiddenButton$ = $('<input>') .attr({ type: 'hidden', id: 'button', name: 'button' }) .appendTo(form$); } hiddenButton$.attr('value', submitButton$.attr('value')); submitButton$.attr("disabled", "disabled"); } }); 

Here is my IsNull function. Use or substitue your own version for IsNull or undefined etc.

function IsNull(obj) { var is; if (obj instanceof jQuery) is = obj.length <= 0; else is = obj === null || typeof obj === 'undefined' || obj == ""; return is; } 

Comments

9

Simple and effective solution is

<form ... onsubmit="myButton.disabled = true; return true;"> ... <input type="submit" name="myButton" value="Submit"> </form> 

Source: here

1 Comment

This is the cleanest and most concise way to do it.
6

Want to submit value of button as well and prevent double form submit?

If you are using button of type submit and want to submit value of button as well, which will not happen if the button is disabled, you can set a form data attribute and test afterwards.

// Add class disableonsubmit to your form $(document).ready(function () { $('form.disableonsubmit').submit(function(e) { if ($(this).data('submitted') === true) { // Form is already submitted console.log('Form is already submitted, waiting response.'); // Stop form from submitting again e.preventDefault(); } else { // Set the data-submitted attribute to true for record $(this).data('submitted', true); } }); }); 

1 Comment

This properly addresses the issue where disabling the button prevents it from being submitted along with the form that most of the other answers did not consider.
5

This should take care of it in your app.

$(":submit").closest("form").submit(function(){ $(':submit').attr('disabled', 'disabled'); }); 

1 Comment

Should be using .prop("disabled", true) instead.
3

A more simplier way. I've tried this and it worked fine for me:

$(':input[type=submit]').prop('disabled', true); 

2 Comments

what does this do? how does this help against the described problem above where disabled button will not send the form?
This will prevent the form from being submitted. The asker wanted the form to continue submission even when the button is disabled.
2

Your code actually works on FF, it doesn't work on Chrome.

This works on FF and Chrome.

$(document).ready(function() { // Solution for disabling the submit temporarily for all the submit buttons. // Avoids double form submit. // Doing it directly on the submit click made the form not to submit in Chrome. // This works in FF and Chrome. $('form').on('submit', function(e){ //console.log('submit2', e, $(this).find('[clicked=true]')); var submit = $(this).find('[clicked=true]')[0]; if (!submit.hasAttribute('disabled')) { submit.setAttribute('disabled', true); setTimeout(function(){ submit.removeAttribute('disabled'); }, 1000); } submit.removeAttribute('clicked'); e.preventDefault(); }); $('[type=submit]').on('click touchstart', function(){ this.setAttribute('clicked', true); }); }); </script> 

Comments

1

The simplest pure javascript solution is to simply disable the button:

<form id="blah" action="foo.php" method="post" onSubmit="return checkForm();"> <button id="blahButton">Submit</button> </form> document.getElementById('blahButton').disabled = true ; 

It works with/without onSubmit. Form stays visible, but nothing can be sumbitted.

Comments

1

In my case i had to put a little delay so that form submits correctly and then disable the button

$(document).on('submit','#for',function() { var $this = $(this); setTimeout(function (){ $this.find(':input[type=submit]').attr('disabled', 'disabled') },1); }); 

Comments

1

The answer by manpreet properly addresses the fact that if you disable the submit button it will not get sent with the other form data. Anything relying on checking the request body for a button value or the presence of 'submit' will fail, as it will be missing entirely.

I created a modified version of that answer that performs the same functionality that does not require $(document).ready() (just make sure the JS code is at the end of the document) and looks a little cleaner.

This searches for all <button> and input(type='button') elements (see jquery :button documentation) within the form as well as all input(type='submit') elements and adds a disabled CSS class to those elements to give them a disabled appearance. This assumes that you have a disabled CSS class for your buttons/inputs, which many popular frontend templates already include; if not, you will have to create the styling you want.

// if a form has the 'form-once-only' class, prevent double submits $('form.form-once-only').submit(function(e) { // check if the form has a isFormSubmitted data attribute set to true; // if so, prevent the submit and return if ($(this).data('isFormSubmitted') === true) { e.preventDefault(); return; } // first time submitting, set the flag to prevent future submissions $(this).data('isFormSubmitted', true); // add a 'disabled' class to all form inputs with type 'submit' and // add a 'disabled' class to all form button elements $(this).find('input[type="submit"], :button').each(function() { $(this).addClass('disabled'); }); }); 

1 Comment

Worth noting that if you use something like jQuery Validate Plugin your form will be disabled even if there are client-side validation errors to correct. I fixed this by calling .valid() in your code and returning if there were client-side validation errors.
0

How to disable submit button

just call a function on onclick event and... return true to submit and false to disable submit. OR call a function on window.onload like :

window.onload = init(); 

and in init() do something like this :

var theForm = document.getElementById(‘theForm’); theForm.onsubmit = // what ever you want to do 

Comments

0

The following worked for me:

var form_enabled = true; $().ready(function(){ // allow the user to submit the form only once each time the page loads $('#form_id').on('submit', function(){ if (form_enabled) { form_enabled = false; return true; } return false; }); }); 

This cancels the submit event if the user tries to submit the form multiple times (by clicking a submit button, pressing Enter, etc.)

Comments

0

I have been using blockUI to avoid browser incompatibilies on disabled or hidden buttons.

http://malsup.com/jquery/block/#element

Then my buttons have a class autobutton:

 $(".autobutton").click( function(event) { var nv = $(this).html(); var nv2 = '<span class="fa fa-circle-o-notch fa-spin" aria-hidden="true"></span> ' + nv; $(this).html(nv2); var form = $(this).parents('form:first'); $(this).block({ message: null }); form.submit(); }); 

Then a form is like that:

<form> .... <button class="autobutton">Submit</button> </form> 

Comments

0

Button Code

<button id="submit" name="submit" type="submit" value="Submit">Submit</button> 

Disable Button

if(When You Disable the button this Case){ $(':input[type="submit"]').prop('disabled', true); }else{ $(':input[type="submit"]').prop('disabled', false); } 

Note: You Case may Be Multiple this time more condition may need

Comments

0

Easy Method:

Javascript & HTML:

$('form#id').submit(function(e){ $(this).children('input[type=submit]').attr('disabled', 'disabled'); // this is just for demonstration e.preventDefault(); return false; }); <!-- begin snippet: js hide: false console: true babel: false -->
<form id="id"> <input type="submit"/> </form>

Note: works perfectly on chrome and edge.

Comments

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.