PDO mysql query problem

Question

I am building a login/signup site with PDO just for fun on wamp...

I am currently building a users online page, when a user accesses any member page it updates a column called online in my mysql table with a unix timestamp.

On the users online page I am trying to find and show all the users who qualify for being online which is being active in the last ten minutes. So far I have this...

$online_users = time() - 600; $q = $dbc -> prepare("SELECT * FROM accounts WHERE online > ?"); $q -> execute(array($online_users)); $online_user = $q -> fetch(PDO::FETCH_ASSOC); while ($q) { echo '<p> ' . $player_details['username'] . ' is online.</p>'; }

The problem I am having is that it is looping over and over again, I would like it to loop through the table once, and display all the users who the mysql query only once...

I am new to PDO and am self learning, so if it is something really daft please excuse me!

Thanks in advance...

You are storing info in $online_user and reading it from $player_details. PHP can warn you about it and help you save time and headaches: have a look at error_reporting(). — Álvaro González
– Álvaro González, Commented Aug 25, 2011 at 8:36

Álvaro González · Accepted Answer · 2011-08-25 08:01:26Z

2

Don't read once first and loop forever afterwards:

$online_user = $q -> fetch(PDO::FETCH_ASSOC); while ($q) {

Instead, read on every loop iteration:

while ($online_user = $q -> fetch(PDO::FETCH_ASSOC)) {

Additionally, don't forget to htmlspecialchars() accordingly.

answered Aug 25, 2011 at 8:01

Álvaro González

147k45 gold badges282 silver badges378 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

carlgcoder Over a year ago

htmlspecialchars?? I thought PDO checked all this for me?? could you elaborate please, and thanks for your quick and helpful answer will accept as soon as I can :)

Álvaro González Over a year ago

PDO has no clue about what your data contains and what you are going to use it for. When a programming language makes assumptions about it, you end up with terrible mistakes like magic quotes.

Andrej · Accepted Answer · 2011-08-25 08:08:34Z

0

Also you use the following code:

$online_users = $q->fetchAll(PDO::FETCH_ASSOC); foreach($online_users as $user) { echo '<p> ' . $user['username'] . ' is online.</p>'; }

answered Aug 25, 2011 at 8:08

Andrej

7,5041 gold badge22 silver badges22 bronze badges

3 Comments

carlgcoder Over a year ago

is there any difference to using the your answer or the one above yours??

Andrej Over a year ago

Principally no. You can try to check speed of each answer and select the best.

Álvaro González Over a year ago

@carlgcoder: This stores the complete result set into a PHP variable. If you only need to use your data once, as in your question, it doesn't really matter... unless you are retrieving 10,000 rows.

Collectives™ on Stack Overflow

PDO mysql query problem

2 Answers 2

2 Comments

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Related