Add exclude-ufs option for mount command#17214
Open
Haoning-Sun wants to merge 4 commits intoAlluxio:master-2.xfrom
Open
Add exclude-ufs option for mount command#17214Haoning-Sun wants to merge 4 commits intoAlluxio:master-2.xfrom
Haoning-Sun wants to merge 4 commits intoAlluxio:master-2.xfrom
Conversation
Contributor
| @LuQQiu Please take a look at whether this is reasonable. Thanks! |
maobaolong requested changes Apr 17, 2023
Contributor
maobaolong left a comment
maobaolong left a comment There was a problem hiding this comment.
@Haoning-Sun Thanks for this feature, left some minor comment.
maobaolong reviewed Apr 24, 2023
| @Override | ||
| public String getUsage() { | ||
| return "mount [--readonly] [--shared] [--option <key=val>] <alluxioPath> <ufsURI>"; | ||
| return "mount [--exclude-ufs/--readonly] [--shared] [--option <key=val>] " |
Contributor
There was a problem hiding this comment.
Sorry for the wrong suggestion for last week, how about this following suggestion?
return "mount <[--exclude-ufs] | [--readonly] [--shared] [--option <key=val>] <alluxioPath> <ufsURI>>"@jiacheliu3 @dbw9580 How about your idea?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add exclude-ufs option for mount command.