[SCALA-54] guide to future in scala #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ldrygala force-pushed the scala-54-futures branch from 0ff8ea7 to a724151 Compare 
ashleyfrieze reviewed May 4, 2020
| val token: String = Await.result(tokenF, Duration.Inf) | ||
| | ||
| val numberF: Future[Int] = Future.successful(5) | ||
| val oddNumberF: Future[Int] = numberF.filter(_ % 2 != 0) // complete with 5 |
Contributor
There was a problem hiding this comment.
These comments are not helping the code to make sense. I think they would be better ahead of the code they describe.
ldrygala force-pushed the scala-54-futures branch from f931d62 to d789b7a Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.