Skip to content

Enhance e2e test for MyDSpace page#5265

Open
oscar-escire wants to merge 11 commits intoDSpace:mainfrom
oscar-escire:Issue/3985
Open

Enhance e2e test for MyDSpace page#5265
oscar-escire wants to merge 11 commits intoDSpace:mainfrom
oscar-escire:Issue/3985

Conversation

@oscar-escire
Copy link
Contributor

References

Description

This PR includes three new tests for the My-DSpace page. Specifically, the three new tests are:

  • Validate that only archived items can be filtered
  • Validate that the drag and drop component works correctly
  • Validate that you can take and perform actions in the workflow

Instructions for Reviewers

  1. Start DSpace in dev mode
  2. Open Cypress with (cypress:run)
  3. Run the my-dspace.ts tests and you will see the three new tests in the list.

List of changes in this PR:

  • Added three new test for my-dspace page

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Note: it may be necessary to create some test objects for this PR; in that case, I do not know how to create these objects to include them in the DSpace base testing environment, but if you tell me how, I can generate the additional PR.

@lgeggleston lgeggleston added testing framework Related specifically to Unit or Integration (e2e) Tests code task labels Mar 6, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Mar 6, 2026
@tdonohue
Copy link
Member

@oscar-escire : Just a quick note: the new e2e tests appear to be failing.

@oscar-escire
Copy link
Contributor Author

@tdonohue: thanks, yes I noted this too, I'm on my way to see why this failing and updating the PR as soon as posible

@github-actions
Copy link

Hi @oscar-escire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@oscar-escire
Copy link
Contributor Author

Hi, @tdonohue: following a few errors that only occurred when running over CI, the tests are now ready.

@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge code task testing framework Related specifically to Unit or Integration (e2e) Tests

3 participants