Fix filter label translation when field is hidden via hideOnIndex#7519
Open
Amoifr wants to merge 1 commit intoEasyCorp:5.xfrom
Open
Fix filter label translation when field is hidden via hideOnIndex#7519Amoifr wants to merge 1 commit intoEasyCorp:5.xfrom
Amoifr wants to merge 1 commit intoEasyCorp:5.xfrom
Conversation
When using useEntityTranslation and a field is hidden via hideOnIndex(), the filter label was not translated because the corresponding FieldDto was null. Now CommonConfigurator uses EntityTranslationIdGenerator to generate the proper translation key when the field is not available. Fix EasyCorp#7512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useEntityTranslationis enabled and a field is hidden viahideOnIndex(), the corresponding filter label was not translatedCommonConfigurator: when$fieldDtois null (field not in collection), it fell back toLabelGenerator::humanize()instead of using the entity translation systemCommonConfiguratorusesEntityTranslationIdGeneratorto generate the proper translation key when the field is not availableTest plan
CommonConfiguratoruseEntityTranslationenabled and a field hidden viahideOnIndex()Fix #7512