Skip to content

Add error on thrift version mismatch, add rebuild script.#4806

Open
feyruzb wants to merge 2 commits intoEricsson:masterfrom
feyruzb:chore/thrift-version-check-on-make-package
Open

Add error on thrift version mismatch, add rebuild script.#4806
feyruzb wants to merge 2 commits intoEricsson:masterfrom
feyruzb:chore/thrift-version-check-on-make-package

Conversation

@feyruzb
Copy link
Collaborator

@feyruzb feyruzb commented Mar 20, 2026

This pull request introduces an automated check to ensure that the CodeChecker API version in the source matches the version installed in the project's virtual environment. If a mismatch is detected, the build process will now fail with a clear error message and instructions for resolving the issue. Additionally, a new script has been added to simplify rebuilding the Thrift API and virtual environment when needed.

API version consistency enforcement:

  • Added variables in the Makefile to extract the API version from the source (setup.py) and from the installed package in either venv or venv_dev (codechecker-api).
  • Introduced a new check_api_version target in the Makefile that compares the source and virtual environment API versions, halting the build with an error and instructions if they do not match.
  • Updated the package target in the Makefile to run the check_api_version step before packaging, ensuring version consistency is always verified.

Developer tooling:

  • Added a new script, web/api/completly-rebuild-thrift.sh, which automates rebuilding the Thrift API, cleaning previous builds, recreating the virtual environment, and rebuilding the package. This script provides clear messaging and usage instructions for developers.
@feyruzb feyruzb requested a review from dkrupp March 20, 2026 15:14
@feyruzb feyruzb self-assigned this Mar 20, 2026
@feyruzb feyruzb requested review from bruntib and vodorok as code owners March 20, 2026 15:14
@feyruzb feyruzb added the dev env ⛑️ Development environment label Mar 20, 2026
@feyruzb feyruzb force-pushed the chore/thrift-version-check-on-make-package branch from 16648d5 to e659203 Compare March 20, 2026 15:39
@feyruzb feyruzb marked this pull request as draft March 20, 2026 15:40
@feyruzb feyruzb marked this pull request as ready for review March 20, 2026 19:00
@bruntib bruntib added this to the release 6.28.0 milestone Mar 23, 2026
@feyruzb feyruzb linked an issue Mar 23, 2026 that may be closed by this pull request
@feyruzb feyruzb changed the title add error on thrift version mismatch, add rebuild script Add error on thrift version mismatch, add rebuild script. Mar 23, 2026
@feyruzb feyruzb requested a review from Discookie March 25, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev env ⛑️ Development environment

2 participants