Skip to content

fix: make shadows transparent #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tvolk131 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: make shadows transparent #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions harbor-ui/src/components/confirm_modal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ pub fn confirm_modal<'a>(
text_color: Some(theme.palette().text),
border: light_container_style(theme).border,
shadow: Shadow {
color: Color::from_rgba8(0, 0, 0, 0.5),
offset: Vector::new(4.0, 4.0),
blur_radius: 8.0,
color: Color::TRANSPARENT,
offset: Vector::ZERO,
blur_radius: 0.0,
},
Comment on lines 56 to 60
Copy link

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Instead of setting all shadow properties to zero/transparent, consider removing the shadow property entirely or using a default/disabled shadow configuration to make the intent clearer.
Copilot uses AI. Check for mistakes.
});

Expand Down Expand Up @@ -140,9 +140,9 @@ pub fn basic_modal<'a>(
text_color: Some(theme.palette().text),
border: light_container_style(theme).border,
shadow: Shadow {
color: Color::from_rgba8(0, 0, 0, 0.5),
offset: Vector::new(4.0, 4.0),
blur_radius: 8.0,
color: Color::TRANSPARENT,
offset: Vector::ZERO,
blur_radius: 0.0,
},
Comment on lines 142 to 146
Copy link

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Instead of setting all shadow properties to zero/transparent, consider removing the shadow property entirely or using a default/disabled shadow configuration to make the intent clearer.
Copilot uses AI. Check for mistakes.
});

Expand Down
6 changes: 3 additions & 3 deletions harbor-ui/src/components/toast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,9 +475,9 @@ fn styled(background: Color, border: Color) -> container::Style {
radius: (4.).into(),
},
shadow: Shadow {
color: Color::from_rgba8(0, 0, 0, 0.25),
offset: Vector::new(-2., -2.),
blur_radius: 4.,
color: Color::TRANSPARENT,
offset: Vector::ZERO,
blur_radius: 0.0,
},
Comment on lines 477 to 481
Copy link

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Instead of setting all shadow properties to zero/transparent, consider removing the shadow property entirely or using a default/disabled shadow configuration to make the intent clearer.
Copilot uses AI. Check for mistakes.
}
}
Expand Down
Loading