Fix latent UAF by boxing Compress to stabilize cinfo address#53
Open
ain5721 wants to merge 1 commit intoImageOptim:mainfrom
Open
Fix latent UAF by boxing Compress to stabilize cinfo address#53ain5721 wants to merge 1 commit intoImageOptim:mainfrom
Compress to stabilize cinfo address#53ain5721 wants to merge 1 commit intoImageOptim:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR boxes the
Compressstruct insideCompressStartedto ensure thejpeg_compress_structmaintains a stable heap address afterstart_compressis called.This prevents internal C back-pointers (like those in progressive huffman or custom destination managers) from becoming dangling pointers to a popped stack frame when the struct is moved.
Fixes issue #52