feat: made changes to avoid spinning up multiple go-rouintes and bettor error handling

[akhilmhdh]

This PR revamps the instant update setup we are doing. Instead of spinning up go-routines it handles it more gracefully.

1. Check for parameter for connection changed or not. If not changed reuse existing connecting
2. Better event registry setup for each connection
3. Each registry is initialled for each CRD as of now

[akhilmhdh]

Tested various states

1. Instant update Off
2. Instant update ON but plan not allowed
3. Instant update ON
4. Instant update reconcile
5. Secret reconcile with states
6. Error handling of queue

[greptile-apps]

Greptile Overview

Greptile Summary

This PR refactors the instant updates (SSE) implementation to avoid spinning up multiple goroutines and improve connection management.

Key changes:

• Replaced channel-based SSE architecture with callback-based pattern to reduce goroutine proliferation
• Implemented connection reuse by checking if params changed before reconnecting
• Added lazy SSE registry initialization (created only when InstantUpdates is enabled)
• Added reconnection logic with exponential backoff (max 5 retries)
• Made SSE errors non-fatal - reconciliation continues with periodic sync as fallback
• Added explicit SSE cleanup in CRD update/delete handlers

Issues found:

• Logic bug: Initial nil value for ServerSentEvents at line 609 breaks preservation logic at line 710
• Race condition: SSE registry operations lack proper locking when updating resource variables map
• Compatibility: Uses Go 1.22 syntax (range over integer, min builtin) - verify minimum Go version

Confidence Score: 2/5

• This PR has critical logic bugs that will prevent the instant updates feature from working correctly
• Score reflects critical initialization bug that breaks SSE registry preservation, potential race condition in concurrent map access, and Go version compatibility issues that may cause compilation failures
• Pay close attention to internal/services/infisicalsecret/reconciler.go lines 609 and 898-926 for the initialization and race condition bugs

Important Files Changed

Filename	Overview
internal/controller/infisicalsecret_controller.go	Added explicit SSE cleanup before context cancellation in update/delete handlers and made SSE errors non-fatal for reconciliation
internal/services/infisicalsecret/reconciler.go	Refactored SSE connection management with lazy initialization and connection reuse logic; contains potential race condition and initialization bug
internal/util/sse/sse.go	Complete rewrite of SSE connection handling with callback-based architecture, reconnection with exponential backoff, and proper lifecycle management; uses Go 1.22 syntax

[greptile-apps]

_{3 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

[varonix0]

question: have we done performance benchmarking on this? if so, how does it look like from your testing?