Conversation
# Fix Ribbon large button image-to-text separator not DPI-scaled ## Summary Resolves [#3225](#3225). The separator between the image and text in Ribbon large buttons was hardcoded at 1 pixel and did not scale with DPI. At 150% DPI (PerMonitorV2), the `_largeImagePadding` scales correctly (3→4, 2→3, 3→4) but the 1px separator stayed at 1px, causing text labels to appear too close to the icons. ## Changes Apply DPI scaling (`FactorDpiY`) to the image-to-text separator, consistent with how image padding is scaled: **Before:** ```csharp contentLayout.Add(new ViewLayoutRibbonSeparator(1, false), ViewDockStyle.Bottom); ``` **After:** ```csharp contentLayout.Add(new ViewLayoutRibbonSeparator((int)(1 * FactorDpiY), false), ViewDockStyle.Bottom); ``` ## Files Modified | File | Change | |------|--------| | `Krypton.Ribbon/View Draw/ViewDrawRibbonGroupButton.cs` | DPI-scale separator in `CreateLargeButtonView()` | | `Krypton.Ribbon/View Draw/ViewDrawRibbonGroupColorButton.cs` | DPI-scale separator in `CreateLargeButtonView()` | | `Krypton.Ribbon/View Draw/ViewDrawRibbonGroupGallery.cs` | DPI-scale separator in `CreateLargeButtonView()` | | `Krypton.Ribbon/View Draw/ViewDrawRibbonGroupLabel.cs` | DPI-scale separator in large label view | | `Krypton.Ribbon/View Draw/ViewDrawRibbonGroupCheckBox.cs` | DPI-scale separator in large check box view | | `Krypton.Ribbon/View Draw/ViewDrawRibbonGroupRadioButton.cs` | DPI-scale separator in large radio button view | | `Documents/Changelog/Changelog.md` | Added changelog entry | ## Testing - Verified at 100% and 150% display scaling with `HighDpiMode.PerMonitorV2` - Manual validation via TestForm Ribbon scenarios - No linter errors; changes are surgical and preserve existing structure ## Breaking Changes None.
PWagner1 added area:ribbon 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Ribbon large button image-to-text separator not DPI-scaled
Summary
Resolves #3225.
The separator between the image and text in Ribbon large buttons was hardcoded at 1 pixel and did not scale with DPI. At 150% DPI (PerMonitorV2), the
_largeImagePaddingscales correctly (3→4, 2→3, 3→4) but the 1px separator stayed at 1px, causing text labels to appear too close to the icons.Changes
Apply DPI scaling (
FactorDpiY) to the image-to-text separator, consistent with how image padding is scaled:Before:
After:
Files Modified
Krypton.Ribbon/View Draw/ViewDrawRibbonGroupButton.csCreateLargeButtonView()Testing
HighDpiMode.PerMonitorV2Breaking Changes
None.