Render icons at resolution matching their size#1272
Open
leekleak wants to merge 3 commits intoMM2-0:mainfrom
Open
Render icons at resolution matching their size#1272leekleak wants to merge 3 commits intoMM2-0:mainfrom
leekleak wants to merge 3 commits intoMM2-0:mainfrom
Conversation
| @MM2-0 Any thoughts on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently some icons suffer from blurriness, especially when the app icon size is small.
That is because those icons are rendered at the app icon size and then scaled to match their actual size. I thought that this was a deliberate choice for performance reasons, but that doesn't really makes sense as when the default app icon size is large, they are rendered large and then downsized, which, obviously, is bad for performance. On the other hand, if the default app icon size is small, the whole process leads to blur. Seems like the worst of both worlds. This changes simply makes it so the icon is rendered at the required resolution to forego any kind of scaling.