Update topic mapping when all documents match zero-shot topics#2451
Draft
huisman wants to merge 2 commits intoMaartenGr:masterfrom
Draft
Update topic mapping when all documents match zero-shot topics#2451huisman wants to merge 2 commits intoMaartenGr:masterfrom
huisman wants to merge 2 commits intoMaartenGr:masterfrom
Conversation
Fix topic labels when all documents match zero-shot topics by updating the topic id mapping even when all documents are matched with zero-shot topics
Owner
| Thank you for the PR! Could you perhaps give an example of how it fixes the issue? That way, I can run some tests. Also, did you test whether the predictions are still correct? I wonder whether the update topics would properly propagate the predictions through the mapping. Lastly, I think you duplicated this: # All documents matches zero-shot topics documents = assigned_documents embeddings = assigned_embeddingsWhich might break things depending on how it was ordered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix topic labels when all documents match zero-shot topics by updating the topic id mapping.
What does this PR do?
When all documents match zero-shot topics, the labels for the topics are not set to the zero-shot topic name.
This PR tries to fix this by updating the topic id/mapping and updating the topic sizes when there are no non-zero-shot topics.
Fixes #2447
Before submitting