fix: make BuildOperationMetrics fields tolerant of missing keys#246
Merged
fortmarek merged 2 commits intoMobileNativeFoundation:masterfrom Mar 3, 2026
Conversation
Xcode projects using `betaFeature_enableExplicitModules` produce xcactivitylog files where BuildOperationMetrics may not contain all expected keys (e.g. clangCacheHits). This causes a DecodingError when parsing these logs. Add a custom Decodable initializer that uses decodeIfPresent with a default of 0 for each field, so parsing succeeds even when keys are absent. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: fortmarek <marekfort@me.com>
fortmarek force-pushed the fix/optional-build-operation-metrics-fields branch from f508fae to 02abbf8 Compare The macos-26 runner has Xcode 26.x installed, not 16.4. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: fortmarek <marekfort@me.com>
fortmarek requested review from CognitiveDisson, aleksandergrzyb, ecamacho and polac24 as code owners 
pepicrft approved these changes Mar 3, 2026
giginet added a commit to giginet/XCLogParser that referenced this pull request Mar 5, 2026
Replace the struct with optional fields approach with an enum that clearly distinguishes between Xcode 15.3-16.x (v15_3) and Xcode 26.4+ (v26_4) formats using associated values. This replaces the decodeIfPresent approach from MobileNativeFoundation#246 with a try-decode-fallback strategy that auto-detects the format. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: giginet <giginet.net@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to tuist/tuist#9507
Summary
betaFeature_enableExplicitModulesproduce xcactivitylog files whereBuildOperationMetricsJSON may not contain all expected keys (e.g.clangCacheHits). This causes aDecodingError.keyNotFoundwhen parsing these logs.Decodableinitializer that usesdecodeIfPresentwith a default of0for each field, so parsing succeeds even when keys are absent.Test plan
testBuildOperationMetricsWithMissingKeys— verifies decoding an empty JSON object{}succeeds with all fields defaulting to 0testBuildOperationMetricsWithPartialKeys— verifies decoding JSON with only swift keys succeeds, with clang fields defaulting to 0