Skip to content

WIP: feat: nix-eval-jobs support for array of derivations #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itzwam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: feat: nix-eval-jobs support for array of derivations #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions src/worker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,15 +236,27 @@ auto collectAttrsForRecursion(nix::EvalState &state, nix::Value *value,
args.forceRecurse ||
path.empty(); // Don't require recurseForDerivations for top-level

for (auto &attr : value->attrs()->lexicographicOrder(state.symbols)) {
const std::string_view &name = state.symbols[attr->name];
attrs.emplace_back(name);

if (!args.forceRecurse && name == "recurseForDerivations") {
const auto *attrv =
value->attrs()->get(nix::EvalState::s.recurseForDerivations);
recurse = state.forceBool(*attrv->value, attrv->pos,
"while evaluating recurseForDerivations");
if (value->type() == nix::nAttrs) {
for (auto &attr : value->attrs()->lexicographicOrder(state.symbols)) {
const std::string_view &name = state.symbols[attr->name];
attrs.emplace_back(name);

if (!args.forceRecurse && name == "recurseForDerivations") {
const auto *attrv =
value->attrs()->get(nix::EvalState::s.recurseForDerivations);
recurse = state.forceBool(*attrv->value, attrv->pos,
"while evaluating recurseForDerivations");
}
}

return recurse ? attrs : std::vector<std::string>{};
}
else if (value->type() == nix::nList) {
auto *list = value->listItems();

for (size_t i = 0; i < list->size(); ++i) {
// Use index as a string key
attrs.emplace_back(std::to_string(i));
}
}

Expand Down