grass.jupyter: Add comprehensive tests for utils.py#7205
Open
saurabh12nxf wants to merge 2 commits intoOSGeo:mainfrom
Open
grass.jupyter: Add comprehensive tests for utils.py#7205saurabh12nxf wants to merge 2 commits intoOSGeo:mainfrom
saurabh12nxf wants to merge 2 commits intoOSGeo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive pytest tests for the
grass.jupyter.utilsmodule, which previously had minimal test coverage.Changes
Added 21 new tests covering 5 critical utility functions:
get_region()- 6 tests validating region dictionary structureget_location_proj_string()- 3 tests for projection string handlingget_rendering_size()- 8 tests for aspect ratio calculationsget_number_of_cores()- 4 tests for CPU allocation logicreproject_region()- 4 tests for coordinate transformation (skipped for XY locations)Testing
All tests pass both in isolation and when run with the full test suite:
pytest python/grass/jupyter/tests/test_utils.py -v✅ 21 passed, 4 skippedpytest python/grass/jupyter/tests/ -v✅ 73 passed, 4 skipped