Fix(keylayout): don’t append actions twice for a given key/key_name combination#211
Open
notpushkin wants to merge 1 commit intoOneDeadKey:mainfrom
Open
Fix(keylayout): don’t append actions twice for a given key/key_name combination#211notpushkin wants to merge 1 commit intoOneDeadKey:mainfrom
notpushkin wants to merge 1 commit intoOneDeadKey:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, keylayout generator outputs an action twice if you specify one char twice on the same key. (This is a weird corner case indeed! I’m using this as a hack to make sure level 4 chars don’t get “upgraded” to level 3, but it might also have more proper use cases.) This patch adds a check for that, and skips extraneous action copies.