Skip to content

Fix SVGs#881

Open
seanlynchwv wants to merge 5 commits intoPHPOffice:masterfrom
seanlynchwv:fix/svg-error
Open

Fix SVGs#881
seanlynchwv wants to merge 5 commits intoPHPOffice:masterfrom
seanlynchwv:fix/svg-error

Conversation

@seanlynchwv
Copy link
Contributor

@seanlynchwv seanlynchwv commented Sep 8, 2025 •
edited
Loading

Description

Adding custom SVGs now works

Fixed by #732 (comment)

Fixes # (issue)

#732

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog
@auto-assign auto-assign bot requested a review from Progi1984 September 8, 2025 16:18
@coveralls
Copy link

coveralls commented Sep 8, 2025 •
edited
Loading

Coverage Status

coverage: 91.644% (+0.001%) from 91.643%
when pulling 6ae84da on seanlynchwv:fix/svg-error
into 7018fd8 on PHPOffice:master.
@seanlynchwv
Copy link
Contributor Author

seanlynchwv commented Sep 22, 2025

Not sure why this is failing now, was passing earlier
@seanlynchwv seanlynchwv closed this Oct 6, 2025
@seanlynchwv seanlynchwv reopened this Oct 6, 2025
Progi1984
Progi1984 requested changes Oct 24, 2025
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanlynchwv Could you add an unit test please ?
@seanlynchwv seanlynchwv mentioned this pull request Jan 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@seanlynchwv @coveralls @Progi1984