This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Open
Conversation
Added a public API for type checking in Roact - Added nameOf function to Type to lookup the string name for any Type - Added TypeMirror module which exposes a subset of types in Type without exposing the internal Roact symbols - Added Roact.Type and Roact.typeOf to expose a type checking API for external use
MisterUncloaked requested review from LPGhatguy, ZoteTheMighty and jeparlefrancais 
LPGhatguy reviewed Aug 9, 2019
LPGhatguy suggested changes Aug 9, 2019
- removed userdata dance in TypeMirror.lua - removed redundant checks in TypeMirror.lua - removed redundant declaration of allowed Roact types
…o be passed to Roact.createElement
MisterUncloaked commented Aug 10, 2019
Contributor Author
| This PR is ready for another pass - tests and docs are updated with Roact.isComponent (formerly Roact.isValidElementType) |
Contributor Author
| This PR should be ready to go at this point. |
jeparlefrancais approved these changes Aug 19, 2019
LPGhatguy suggested changes Aug 19, 2019
- removed Without Type Checking example that used undocumented internals - removed info blurb about only accepting component classes for additional safety
Contributor Author
| @LPGhatguy anything else you'd like to see here before we get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227
Added a public API for type checking in Roact
Checklist before submitting:
CHANGELOG.md