Fix to check ActiveRecord prefix / suffix#432
Open
zaru wants to merge 2 commits intoRolifyCommunity:masterfrom
Open
Fix to check ActiveRecord prefix / suffix#432zaru wants to merge 2 commits intoRolifyCommunity:masterfrom
zaru wants to merge 2 commits intoRolifyCommunity:masterfrom
Conversation
EppO requested changes Nov 20, 2017
Member
EppO left a comment
EppO left a comment There was a problem hiding this comment.
Thanks for your contribution,
A test with ActiveRecord::Base.table_name_prefix set would be needed to check what is the impact when prefix is non-empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296
When using
config.active_record.table_name_prefixin ActiveRecord, the name of join table is not changed. This PR works well in my environment, but please advise if there is any problem.