Implement proper STI support in Rolify#599
Open
bopm wants to merge 1 commit intoRolifyCommunity:masterfrom
Open
Implement proper STI support in Rolify#599bopm wants to merge 1 commit intoRolifyCommunity:masterfrom
bopm wants to merge 1 commit intoRolifyCommunity:masterfrom
Conversation
Author
| And then I noticed #517, dunno what to do now :) |
bopm force-pushed the feature/proper-sti-support branch from 995bad0 to 7e42eae Compare bopm force-pushed the feature/proper-sti-support branch from 7e42eae to 56f19e1 Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current approach to ActiveRecord STI is a bit misleading as in practice polymorphic association will always fallback to the base model.
This PR trying to address that by setting resource type accordingly from reflection.