Conversation
newpavlov commented Mar 20, 2026
| mod aarch64_sha2; | ||
| use aarch64_sha2::compress; | ||
| target_arch = "aarch64", | ||
| sha2_backend = "aarch64-sha3", |
Member Author
There was a problem hiding this comment.
Maybe we should introduce separate flags for SHA-256 and SHA-512 backends, i.e. sha2_sha256_backend and sha2_sha512_backend?
newpavlov force-pushed the sha2/refactor_backends branch from 1324c0f to 8bce044 Compare 
tarcieri approved these changes Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorganizes backends structure and related configuration flags. Now backends like
x86_shaniexposecompressfunction marked with#[target_feature(enable = "...")]which has to be called usingunsafeafter an appropriate run-time or compile-time check. Autodetection is now handled by the (default) fallbackcfg_if!branch instead of doing it in the backend modules.sha2_backendnow forces selection of the specified backend and if necceccary checks at compile time whether target features required by the backend were properly enabled.sha2_backend="soft-compact"andsha2_backend="riscv-zknh-compact"configuration flags are replaced bysha2_backend_soft="compact"andsha2_backend_riscv_zknh="compact"flags respectively.TODO: update changelog and readme