Add reload prompt for updating service worker#2574
Open
FireMasterK wants to merge 1 commit intomasterfrom
Open
Add reload prompt for updating service worker#2574FireMasterK wants to merge 1 commit intomasterfrom
FireMasterK wants to merge 1 commit intomasterfrom
Conversation
FireMasterK commented Jun 19, 2023
Comment on lines +13 to +20
| <div v-if="offlineReady || needRefresh" class="pwa-toast" role="alert"> | ||
| <div class="message"> | ||
| <span v-if="offlineReady"> App ready to work offline </span> | ||
| <span v-else> New content available, click on reload button to update. </span> | ||
| </div> | ||
| <button v-if="needRefresh" @click="updateServiceWorker()">Reload</button> | ||
| <button @click="close">Close</button> | ||
| </div> |
Member Author
There was a problem hiding this comment.
Copied this from the documentation, CSS needs to be updated for various themes, and these strings need to be localized.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1199