Open
Conversation
| The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Automated Review: APPROVE
Hook Review: BackGeoOracle (0xB13250f0Dc8ec6dE297E81CDA8142DB51860BaC4) on Ethereum
Address Bitmask Verification
Address last 14 bits: 0x3AC4 (11101011000100)
| Bit | Flag | Address | JSON | Source |
|---|---|---|---|---|
| 13 | beforeInitialize | ✅ true | true | true |
| 12 | afterInitialize | ✅ true | true | true |
| 11 | beforeAddLiquidity | ✅ true | true | true |
| 10 | afterAddLiquidity | ✅ false | false | false |
| 9 | beforeRemoveLiquidity | ✅ true | true | true |
| 8 | afterRemoveLiquidity | ✅ false | false | false |
| 7 | beforeSwap | ✅ true | true | true |
| 6 | afterSwap | ✅ true | true | true |
| 5 | beforeDonate | ✅ false | false | false |
| 4 | afterDonate | ✅ false | false | false |
| 3 | beforeSwapReturnsDelta | ✅ false | false | false |
| 2 | afterSwapReturnsDelta | ✅ true | true | true |
| 1 | afterAddLiquidityReturnsDelta | ✅ false | false | false |
| 0 | afterRemoveLiquidityReturnsDelta | ✅ false | false | false |
All 14 flags match the address bitmask and getHookPermissions() in source.
Properties Verification
- dynamicFee: false ✅ —
_beforeSwapreturns0for the fee override; noupdateDynamicLPFee()calls anywhere. - upgradeable: false ✅ — No proxy patterns, no
delegatecall, noSELFDESTRUCT. Standard non-upgradeable contract. - requiresCustomSwapData: false ✅ — Neither
_beforeSwapnor_afterSwapreads fromhookData; thebytes calldataparameter is unused in both.
Metadata Verification
- name:
BackGeoOraclematchesContractNamefrom Etherscan ✅ - chain / chainId:
ethereum/1✅ - verifiedSource:
true— confirmed verified on Etherscan ✅ - deployer: Valid
0xaddress format ✅ - Proxy: Not a proxy contract ✅
Notes
The hook only supports exactIn swaps (reverts with NotExactIn if amountSpecified >= 0), and the _afterSwap backrun logic requires the calling router to implement IMsgSender.msgSender() (reverts with CallingRouterDoesNotReturnSender otherwise when a backrun is triggered). Neither condition relates to hookData, so requiresCustomSwapData: false is correct.
All flags, properties, and metadata are accurate. ✅
A human reviewer must still approve this PR before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BackGeoOracle is a TWAP oracle hook with built-in backrun protection. It records on-chain price observations and automatically executes reverse swaps after large price-impact trades to restore the pool price toward the geometric mean, crediting the original swapper with ERC6909 tokens. Only exact-input swaps are supported, and liquidity positions must be full-range.
Flags
Properties
Warnings
IMsgSender.msgSender()when a backrun is triggered; routers that don't implement this interface will cause the transaction to revert. This is a router compatibility constraint, not ahookDatarequirement.NotExactIn.Closes #373